Increase targetSdkVersion to 19.

Increase targetSdkVersion to 19.

BUG=317754
NOTRY=true
TBR=abarth@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236540

[Ted C, 2013-11-14 23:23:15]

lgtm

[Yaron, 2013-11-14 23:26:04]

On 2013/11/14 23:23:15, Ted C wrote:
> lgtm

Ted: did you look at the notes on
http://developer.android.com/reference/android/os/Build.VERSION_CODES.html#KI...

Would the UI aspects affect us?

[whywhat, 2013-11-14 23:32:43]

lgtm

[frankf, 2013-11-14 23:34:58]

You're missing some stuff, all manifests (some don't have targetSdk though):

android_webview/test/shell/AndroidManifest.xml
android_webview/javatests/AndroidManifest.xml
remoting/android/java/AndroidManifest.xml
build/android/AndroidManifest.xml
build/android/tests/multiple_proguards/AndroidManifest.xml
testing/android/AndroidManifest.xml
mojo/shell/android/apk/AndroidManifest.xml
tools/android/memconsumer/java/AndroidManifest.xml
chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml
chrome/android/testshell/javatests/AndroidManifest.xml
chrome/android/testshell/java/AndroidManifest.xml
content/shell/android/shell_apk/AndroidManifest.xml
content/shell/android/browsertests_apk/AndroidManifest.xml
content/shell/android/javatests/AndroidManifest.xml
content/shell/android/linker_test_apk/AndroidManifest.xml

[Ted C, 2013-11-14 23:44:45]

On 2013/11/14 23:26:04, Yaron wrote:
> On 2013/11/14 23:23:15, Ted C wrote:
> > lgtm
> 
> Ted: did you look at the notes on
>
http://developer.android.com/reference/android/os/Build.VERSION_CODES.html#KI...
> 
> Would the UI aspects affect us?

None of them raise immediate alarms.

[navabi, 2013-11-15 00:12:40]

On 2013/11/14 23:34:58, frankf wrote:
> You're missing some stuff, all manifests (some don't have targetSdk though):
> 
> android_webview/test/shell/AndroidManifest.xml
> android_webview/javatests/AndroidManifest.xml
> remoting/android/java/AndroidManifest.xml
> build/android/AndroidManifest.xml
> build/android/tests/multiple_proguards/AndroidManifest.xml
> testing/android/AndroidManifest.xml
> mojo/shell/android/apk/AndroidManifest.xml
> tools/android/memconsumer/java/AndroidManifest.xml
> chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml
> chrome/android/testshell/javatests/AndroidManifest.xml
> chrome/android/testshell/java/AndroidManifest.xml
> content/shell/android/shell_apk/AndroidManifest.xml
> content/shell/android/browsertests_apk/AndroidManifest.xml
> content/shell/android/javatests/AndroidManifest.xml
> content/shell/android/linker_test_apk/AndroidManifest.xml

The only ones from that list that I am missing (AFAIK) are android_webview
files. For the rest any targetSdkVersion that was 18 is now 19. Let me know if
you know of any specific file I am missing.

[navabi, 2013-11-15 00:13:18]

On 2013/11/15 00:12:40, navabi wrote:
> On 2013/11/14 23:34:58, frankf wrote:
> > You're missing some stuff, all manifests (some don't have targetSdk though):
> > 
> > android_webview/test/shell/AndroidManifest.xml
> > android_webview/javatests/AndroidManifest.xml
> > remoting/android/java/AndroidManifest.xml
> > build/android/AndroidManifest.xml
> > build/android/tests/multiple_proguards/AndroidManifest.xml
> > testing/android/AndroidManifest.xml
> > mojo/shell/android/apk/AndroidManifest.xml
> > tools/android/memconsumer/java/AndroidManifest.xml
> > chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml
> > chrome/android/testshell/javatests/AndroidManifest.xml
> > chrome/android/testshell/java/AndroidManifest.xml
> > content/shell/android/shell_apk/AndroidManifest.xml
> > content/shell/android/browsertests_apk/AndroidManifest.xml
> > content/shell/android/javatests/AndroidManifest.xml
> > content/shell/android/linker_test_apk/AndroidManifest.xml
> 
> The only ones from that list that I am missing (AFAIK) are android_webview
> files. For the rest any targetSdkVersion that was 18 is now 19. Let me know if
> you know of any specific file I am missing.

Sorry, should've mentioned I left about the android_webview ones since WebView
is still on 18. That will change once WebView rolls to 19.

[frankf, 2013-11-15 00:18:54]

On 2013/11/15 00:13:18, navabi wrote:
> On 2013/11/15 00:12:40, navabi wrote:
> > On 2013/11/14 23:34:58, frankf wrote:
> > > You're missing some stuff, all manifests (some don't have targetSdk
though):
> > > 
> > > android_webview/test/shell/AndroidManifest.xml
> > > android_webview/javatests/AndroidManifest.xml
> > > remoting/android/java/AndroidManifest.xml
> > > build/android/AndroidManifest.xml
> > > build/android/tests/multiple_proguards/AndroidManifest.xml
> > > testing/android/AndroidManifest.xml
> > > mojo/shell/android/apk/AndroidManifest.xml
> > > tools/android/memconsumer/java/AndroidManifest.xml
> > > chrome/test/chromedriver/test/webview_shell/java/AndroidManifest.xml
> > > chrome/android/testshell/javatests/AndroidManifest.xml
> > > chrome/android/testshell/java/AndroidManifest.xml
> > > content/shell/android/shell_apk/AndroidManifest.xml
> > > content/shell/android/browsertests_apk/AndroidManifest.xml
> > > content/shell/android/javatests/AndroidManifest.xml
> > > content/shell/android/linker_test_apk/AndroidManifest.xml
> > 
> > The only ones from that list that I am missing (AFAIK) are android_webview
> > files. For the rest any targetSdkVersion that was 18 is now 19. Let me know
if
> > you know of any specific file I am missing.
> 
> Sorry, should've mentioned I left about the android_webview ones since WebView
> is still on 18. That will change once WebView rolls to 19.

I think we should update tools/android/memconsumer/java/AndroidManifest.xml as
well.

otherwise, lgtm

[Yaron, 2013-11-15 00:55:11]

lgtm

[navabi, 2013-11-15 01:28:11]

On 2013/11/15 00:55:11, Yaron wrote:
> lgtm

Frank, my tools/android/memconsumer/java/AndroidManifest.xml does not have
targetSdkVersion mentioned at all. Let me know if yours does.

[frankf, 2013-11-15 01:41:21]

On 2013/11/15 01:28:11, navabi wrote:
> On 2013/11/15 00:55:11, Yaron wrote:
> > lgtm
> 
> Frank, my tools/android/memconsumer/java/AndroidManifest.xml does not have
> targetSdkVersion mentioned at all. Let me know if yours does.

Ya, you're right. nvm them. still lgtm.

[commit-bot: I haz the power, 2013-11-15 04:05:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/68203025/1

[commit-bot: I haz the power, 2013-11-15 05:33:42]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[navabi, 2013-11-15 21:00:52]

Need OWNERS for mojo/shell/android/apk/AndroidManifest.xml

[abarth-chromium, 2013-11-18 06:47:24]

LGTM, but I'm not an owner.  Feel free to TBR that part of the change to me to
make the bots happy.

[abarth-chromium, 2013-11-18 06:47:37]

(That part = the mojo part)

[commit-bot: I haz the power, 2013-11-21 00:24:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/68203025/1

[commit-bot: I haz the power, 2013-11-21 01:15:20]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2013-11-21 17:19:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/navabi@google.com/68203025/1

[commit-bot: I haz the power, 2013-11-21 17:19:25]

Change committed as 236540