Issue 68203018: Revert "Revert "switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68203018: Revert "Revert "switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice"" (Closed)

Created:
7 years, 1 month ago by reed1

Modified:
7 years, 1 month ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Revert "Revert "switch GatherPixelRefs to use SkBaseDevice instead of SkBitmapDevice"" This reverts commit ff0152ec5e2a0faf38ae1a317c5d77df08139104. BUG= Committed: https://code.google.com/p/skia/source/detail?r=12271

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+72 lines, -54 lines)			Patch
M	include/core/SkBitmapDevice.h	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	include/core/SkDevice.h	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	include/gpu/SkGpuDevice.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/core/SkBitmapDevice.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	src/utils/SkPictureUtils.cpp	View	3 chunks	+65 lines, -30 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

reed1

7 years, 1 month ago (2013-11-13 16:02:23 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r12271 (presubmit successful).

Expand Messages | Collapse Messages