Mojo: Make tests under mojo/public use our own run_all_unittests.cc.

Mojo: Make tests under mojo/public use our own run_all_unittests.cc.

Split off run_all_unittests.cc to its own static library and make the
various test targets under mojo/public depend on that. This way they
don't have to call CoreImpl::Init() themselves.

Also temporarily disable public/bindings/sample/sample_test.cc until I
convert it to a gtest, which I'll do separately.

R=sky@chromium.org, sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234280

[sky, 2013-11-11 21:02:12]

LGTM

[viettrungluu, 2013-11-11 21:12:08]

Committed patchset #1 manually as r234280 (presubmit successful).

[darin (slow to review), 2013-11-11 21:31:42]

https://codereview.chromium.org/68203005/diff/1/mojo/public/tests/bindings_co...
File mojo/public/tests/bindings_connector_unittest.cc (right):

https://codereview.chromium.org/68203005/diff/1/mojo/public/tests/bindings_co...
mojo/public/tests/bindings_connector_unittest.cc:8: #include "base/basictypes.h"
I meant to make this be clean of base/ dependencies, so MOJO_OVERRIDE instead of
OVERRIDE. I can also clean this up later.

[viettrungluu, 2013-11-11 21:56:06]

https://codereview.chromium.org/68203005/diff/1/mojo/public/tests/bindings_co...
File mojo/public/tests/bindings_connector_unittest.cc (right):

https://codereview.chromium.org/68203005/diff/1/mojo/public/tests/bindings_co...
mojo/public/tests/bindings_connector_unittest.cc:8: #include "base/basictypes.h"
On 2013/11/11 21:31:42, darin wrote:
> I meant to make this be clean of base/ dependencies, so MOJO_OVERRIDE instead
of
> OVERRIDE. I can also clean this up later.

I can take care of this.

[viettrungluu, 2013-11-11 22:20:45]

On 2013/11/11 21:56:06, viettrungluu wrote:
>
https://codereview.chromium.org/68203005/diff/1/mojo/public/tests/bindings_co...
> File mojo/public/tests/bindings_connector_unittest.cc (right):
> 
>
https://codereview.chromium.org/68203005/diff/1/mojo/public/tests/bindings_co...
> mojo/public/tests/bindings_connector_unittest.cc:8: #include
"base/basictypes.h"
> On 2013/11/11 21:31:42, darin wrote:
> > I meant to make this be clean of base/ dependencies, so MOJO_OVERRIDE
instead
> of
> > OVERRIDE. I can also clean this up later.
> 
> I can take care of this.

base/basictypes.h was also needed for arraysize(). I got rid of it (substituting
a manual calculation), but maybe we want a Mojo version of it?

[darin (slow to review), 2013-11-11 22:28:09]

Yeah, I had a similar thought. Hmm...


On Mon, Nov 11, 2013 at 2:20 PM, <viettrungluu@chromium.org> wrote:

> On 2013/11/11 21:56:06, viettrungluu wrote:
>
> https://codereview.chromium.org/68203005/diff/1/mojo/
> public/tests/bindings_connector_unittest.cc
>
>> File mojo/public/tests/bindings_connector_unittest.cc (right):
>>
>
>
> https://codereview.chromium.org/68203005/diff/1/mojo/
> public/tests/bindings_connector_unittest.cc#newcode8
>
>> mojo/public/tests/bindings_connector_unittest.cc:8: #include
>>
> "base/basictypes.h"
>
>> On 2013/11/11 21:31:42, darin wrote:
>> > I meant to make this be clean of base/ dependencies, so MOJO_OVERRIDE
>>
> instead
>
>> of
>> > OVERRIDE. I can also clean this up later.
>>
>
>  I can take care of this.
>>
>
> base/basictypes.h was also needed for arraysize(). I got rid of it
> (substituting
> a manual calculation), but maybe we want a Mojo version of it?
>
> https://codereview.chromium.org/68203005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.