Include version number with ClearKey and WideVine cdmadapters

Include version number with ClearKey and Widevine cdmadapters

BUG=426252
TEST=compiles, verified version number shows up on Windows

Committed: https://crrev.com/5c5f7eb9c1d6500f0bac3e2e4e3fa1ee32d94576
Cr-Commit-Position: refs/heads/master@{#302485}

[jrummell, 2014-10-31 17:35:01]

jrummell@chromium.org changed reviewers:
+ ddorwin@chromium.org, xhwang@chromium.org

[jrummell, 2014-10-31 17:35:01]

PTAL. The version numbers do show up on the dlls for Windows.

[xhwang, 2014-10-31 18:25:04]

Looking good. I just have a question for possible improvement.

https://codereview.chromium.org/681983004/diff/1/media/media_cdm.gypi
File media/media_cdm.gypi (right):

https://codereview.chromium.org/681983004/diff/1/media/media_cdm.gypi#newcode123
media/media_cdm.gypi:123: },
Is there a way to actually put these in the cdmadapter target, but somehow be
able to customize 

 'sources': [
             'clearkeycdmadapter.ver',
  ],

or INTERNAL_NAME and ORIGINAL_FILENAME directly?

[jrummell, 2014-10-31 23:03:12]

https://codereview.chromium.org/681983004/diff/1/media/media_cdm.gypi
File media/media_cdm.gypi (right):

https://codereview.chromium.org/681983004/diff/1/media/media_cdm.gypi#newcode123
media/media_cdm.gypi:123: },
On 2014/10/31 18:25:04, xhwang wrote:
> Is there a way to actually put these in the cdmadapter target, but somehow be
> able to customize 
> 
>  'sources': [
>              'clearkeycdmadapter.ver',
>   ],
> 
> or INTERNAL_NAME and ORIGINAL_FILENAME directly?

From what I've been able to tell, it appears that variables are limited in
scope. The only way to pass them would be to include a .gypi file (which would
see any variables defined before the include). I don't think that will help
much, since it would still be independent of the cdmadapter rules.

Given that .gyp will be going away, is it worth putting in the effort to try to
have the version stuff in one place?

[xhwang, 2014-11-03 19:41:52]

I see. Thanks for the investigation. LGTM

[jrummell, 2014-11-03 20:47:51]

The CQ bit was checked by jrummell@chromium.org

[commit-bot: I haz the power, 2014-11-03 20:49:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/681983004/1

[commit-bot: I haz the power, 2014-11-03 21:32:55]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-03 21:35:11]

Patchset 1 (id:??) landed as
https://crrev.com/5c5f7eb9c1d6500f0bac3e2e4e3fa1ee32d94576
Cr-Commit-Position: refs/heads/master@{#302485}

[xhwang, 2014-11-05 03:32:07]

https://codereview.chromium.org/681983004/diff/1/media/clearkeycdmadapter.ver
File media/clearkeycdmadapter.ver (right):

https://codereview.chromium.org/681983004/diff/1/media/clearkeycdmadapter.ver...
media/clearkeycdmadapter.ver:1: INTERNAL_NAME=clearkeycdmadapter_dll
I missed this in this CL. Now we have "File Description" and "Product name"
being "Google Chrome", which isn't accurate. We should fix this with better
strings.