Clear the bluetooth discoverable bit when OOBE is finished on Remora.

Clear the bluetooth discoverable bit when OOBE is finished on Remora.

BUG=427089
Committed: https://crrev.com/27600066b205599d8e88bf6761968bab51e8e7dd
Cr-Commit-Position: refs/heads/master@{#301543}

[Zachary Kuznia, 2014-10-27 21:25:02]

zork@chromium.org changed reviewers:
+ achuith@chromium.org

[Zachary Kuznia, 2014-10-27 21:25:03]

Please take a look.

[achuithb, 2014-10-27 21:32:34]

https://codereview.chromium.org/681903002/diff/1/components/pairing/bluetooth...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/681903002/diff/1/components/pairing/bluetooth...
components/pairing/bluetooth_host_pairing_controller.cc:68: Reset();
This also calls ChangeStage, which calls the observers of this destructed
object, and they may actually perform some action using a deleted pointer.

https://codereview.chromium.org/681903002/diff/1/components/pairing/bluetooth...
components/pairing/bluetooth_host_pairing_controller.cc:152:
ChangeStage(STAGE_NONE);
Should we get rid of this?

[Zachary Kuznia, 2014-10-27 21:40:24]

Simplified as discussed.

[achuithb, 2014-10-27 21:47:32]

lgtm

https://codereview.chromium.org/681903002/diff/20001/components/pairing/bluet...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/681903002/diff/20001/components/pairing/bluet...
components/pairing/bluetooth_host_pairing_controller.cc:73: adapter_ = NULL;
nit: this is not necessary since this object's data members are immediately
going to get deleted, but up to you.

[Zachary Kuznia, 2014-10-28 00:01:42]

https://codereview.chromium.org/681903002/diff/20001/components/pairing/bluet...
File components/pairing/bluetooth_host_pairing_controller.cc (right):

https://codereview.chromium.org/681903002/diff/20001/components/pairing/bluet...
components/pairing/bluetooth_host_pairing_controller.cc:73: adapter_ = NULL;
On 2014/10/27 21:47:32, achuithb wrote:
> nit: this is not necessary since this object's data members are immediately
> going to get deleted, but up to you.

Acknowledged.

[Zachary Kuznia, 2014-10-28 00:01:45]

The CQ bit was checked by zork@chromium.org

[commit-bot: I haz the power, 2014-10-28 00:07:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/681903002/20001

[commit-bot: I haz the power, 2014-10-28 01:28:42]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-28 01:29:53]

Patchset 2 (id:??) landed as
https://crrev.com/27600066b205599d8e88bf6761968bab51e8e7dd
Cr-Commit-Position: refs/heads/master@{#301543}