Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: ui/wm/core/default_activation_client.h

Issue 681873003: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/wm/core/cursor_manager_unittest.cc ('k') | ui/wm/core/default_activation_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef UI_WM_CORE_DEFAULT_ACTIVATION_CLIENT_H_ 5 #ifndef UI_WM_CORE_DEFAULT_ACTIVATION_CLIENT_H_
6 #define UI_WM_CORE_DEFAULT_ACTIVATION_CLIENT_H_ 6 #define UI_WM_CORE_DEFAULT_ACTIVATION_CLIENT_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 14 matching lines...) Expand all
25 // Simple ActivationClient implementation for use by tests and other targets 25 // Simple ActivationClient implementation for use by tests and other targets
26 // that just need basic behavior (e.g. activate windows whenever requested, 26 // that just need basic behavior (e.g. activate windows whenever requested,
27 // restack windows at the top when they're activated, etc.). This object deletes 27 // restack windows at the top when they're activated, etc.). This object deletes
28 // itself when the root window it is associated with is destroyed. 28 // itself when the root window it is associated with is destroyed.
29 class WM_EXPORT DefaultActivationClient : public aura::client::ActivationClient, 29 class WM_EXPORT DefaultActivationClient : public aura::client::ActivationClient,
30 public aura::WindowObserver { 30 public aura::WindowObserver {
31 public: 31 public:
32 explicit DefaultActivationClient(aura::Window* root_window); 32 explicit DefaultActivationClient(aura::Window* root_window);
33 33
34 // Overridden from aura::client::ActivationClient: 34 // Overridden from aura::client::ActivationClient:
35 virtual void AddObserver( 35 void AddObserver(aura::client::ActivationChangeObserver* observer) override;
36 void RemoveObserver(
36 aura::client::ActivationChangeObserver* observer) override; 37 aura::client::ActivationChangeObserver* observer) override;
37 virtual void RemoveObserver( 38 void ActivateWindow(aura::Window* window) override;
38 aura::client::ActivationChangeObserver* observer) override; 39 void DeactivateWindow(aura::Window* window) override;
39 virtual void ActivateWindow(aura::Window* window) override; 40 aura::Window* GetActiveWindow() override;
40 virtual void DeactivateWindow(aura::Window* window) override; 41 aura::Window* GetActivatableWindow(aura::Window* window) override;
41 virtual aura::Window* GetActiveWindow() override; 42 aura::Window* GetToplevelWindow(aura::Window* window) override;
42 virtual aura::Window* GetActivatableWindow(aura::Window* window) override; 43 bool CanActivateWindow(aura::Window* window) const override;
43 virtual aura::Window* GetToplevelWindow(aura::Window* window) override;
44 virtual bool CanActivateWindow(aura::Window* window) const override;
45 44
46 // Overridden from WindowObserver: 45 // Overridden from WindowObserver:
47 virtual void OnWindowDestroyed(aura::Window* window) override; 46 void OnWindowDestroyed(aura::Window* window) override;
48 47
49 private: 48 private:
50 class Deleter; 49 class Deleter;
51 50
52 virtual ~DefaultActivationClient(); 51 ~DefaultActivationClient() override;
53 void RemoveActiveWindow(aura::Window* window); 52 void RemoveActiveWindow(aura::Window* window);
54 53
55 // This class explicitly does NOT store the active window in a window property 54 // This class explicitly does NOT store the active window in a window property
56 // to make sure that ActivationChangeObserver is not treated as part of the 55 // to make sure that ActivationChangeObserver is not treated as part of the
57 // aura API. Assumptions to that end will cause tests that use this client to 56 // aura API. Assumptions to that end will cause tests that use this client to
58 // fail. 57 // fail.
59 std::vector<aura::Window*> active_windows_; 58 std::vector<aura::Window*> active_windows_;
60 59
61 // The window which was active before the currently active one. 60 // The window which was active before the currently active one.
62 aura::Window* last_active_; 61 aura::Window* last_active_;
63 62
64 ObserverList<aura::client::ActivationChangeObserver> observers_; 63 ObserverList<aura::client::ActivationChangeObserver> observers_;
65 64
66 DISALLOW_COPY_AND_ASSIGN(DefaultActivationClient); 65 DISALLOW_COPY_AND_ASSIGN(DefaultActivationClient);
67 }; 66 };
68 67
69 } // namespace wm 68 } // namespace wm
70 69
71 #endif // UI_WM_CORE_DEFAULT_ACTIVATION_CLIENT_H_ 70 #endif // UI_WM_CORE_DEFAULT_ACTIVATION_CLIENT_H_
OLDNEW
« no previous file with comments | « ui/wm/core/cursor_manager_unittest.cc ('k') | ui/wm/core/default_activation_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698