Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: ui/app_list/views/folder_header_view_unittest.cc

Issue 681873002: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ui/app_list/views/folder_header_view.cc ('k') | ui/app_list/views/page_switcher.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/app_list/views/folder_header_view.h" 5 #include "ui/app_list/views/folder_header_view.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 10 matching lines...) Expand all
21 #include "ui/views/test/views_test_base.h" 21 #include "ui/views/test/views_test_base.h"
22 22
23 namespace app_list { 23 namespace app_list {
24 namespace test { 24 namespace test {
25 25
26 namespace { 26 namespace {
27 27
28 class TestFolderHeaderViewDelegate : public FolderHeaderViewDelegate { 28 class TestFolderHeaderViewDelegate : public FolderHeaderViewDelegate {
29 public: 29 public:
30 TestFolderHeaderViewDelegate() {} 30 TestFolderHeaderViewDelegate() {}
31 virtual ~TestFolderHeaderViewDelegate() {} 31 ~TestFolderHeaderViewDelegate() override {}
32 32
33 // FolderHeaderViewDelegate 33 // FolderHeaderViewDelegate
34 virtual void NavigateBack(AppListFolderItem* item, 34 void NavigateBack(AppListFolderItem* item,
35 const ui::Event& event_flags) override {} 35 const ui::Event& event_flags) override {}
36 36
37 virtual void GiveBackFocusToSearchBox() override {} 37 void GiveBackFocusToSearchBox() override {}
38 38
39 virtual void SetItemName(AppListFolderItem* item, 39 void SetItemName(AppListFolderItem* item, const std::string& name) override {
40 const std::string& name) override {
41 folder_name_ = name; 40 folder_name_ = name;
42 } 41 }
43 42
44 const std::string& folder_name() const { return folder_name_; } 43 const std::string& folder_name() const { return folder_name_; }
45 44
46 private: 45 private:
47 std::string folder_name_; 46 std::string folder_name_;
48 47
49 DISALLOW_COPY_AND_ASSIGN(TestFolderHeaderViewDelegate); 48 DISALLOW_COPY_AND_ASSIGN(TestFolderHeaderViewDelegate);
50 }; 49 };
51 50
52 } // namespace 51 } // namespace
53 52
54 class FolderHeaderViewTest : public views::ViewsTestBase { 53 class FolderHeaderViewTest : public views::ViewsTestBase {
55 public: 54 public:
56 FolderHeaderViewTest() {} 55 FolderHeaderViewTest() {}
57 virtual ~FolderHeaderViewTest() {} 56 ~FolderHeaderViewTest() override {}
58 57
59 // testing::Test overrides: 58 // testing::Test overrides:
60 virtual void SetUp() override { 59 void SetUp() override {
61 views::ViewsTestBase::SetUp(); 60 views::ViewsTestBase::SetUp();
62 model_.reset(new AppListTestModel); 61 model_.reset(new AppListTestModel);
63 model_->SetFoldersEnabled(true); 62 model_->SetFoldersEnabled(true);
64 63
65 delegate_.reset(new TestFolderHeaderViewDelegate); 64 delegate_.reset(new TestFolderHeaderViewDelegate);
66 folder_header_view_.reset(new FolderHeaderView(delegate_.get())); 65 folder_header_view_.reset(new FolderHeaderView(delegate_.get()));
67 } 66 }
68 67
69 virtual void TearDown() override { 68 void TearDown() override {
70 folder_header_view_.reset(); // Release apps grid view before models. 69 folder_header_view_.reset(); // Release apps grid view before models.
71 delegate_.reset(); 70 delegate_.reset();
72 views::ViewsTestBase::TearDown(); 71 views::ViewsTestBase::TearDown();
73 } 72 }
74 73
75 protected: 74 protected:
76 void UpdateFolderName(const std::string& name) { 75 void UpdateFolderName(const std::string& name) {
77 base::string16 folder_name = base::UTF8ToUTF16(name); 76 base::string16 folder_name = base::UTF8ToUTF16(name);
78 folder_header_view_->SetFolderNameForTest(folder_name); 77 folder_header_view_->SetFolderNameForTest(folder_name);
79 folder_header_view_->ContentsChanged(NULL, folder_name); 78 folder_header_view_->ContentsChanged(NULL, folder_name);
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
128 127
129 TEST_F(FolderHeaderViewTest, OemFolderNameNotEditable) { 128 TEST_F(FolderHeaderViewTest, OemFolderNameNotEditable) {
130 AppListFolderItem* folder_item = model_->CreateAndAddOemFolder("oem folder"); 129 AppListFolderItem* folder_item = model_->CreateAndAddOemFolder("oem folder");
131 folder_header_view_->SetFolderItem(folder_item); 130 folder_header_view_->SetFolderItem(folder_item);
132 EXPECT_EQ("", GetFolderNameFromUI()); 131 EXPECT_EQ("", GetFolderNameFromUI());
133 EXPECT_FALSE(CanEditFolderName()); 132 EXPECT_FALSE(CanEditFolderName());
134 } 133 }
135 134
136 } // namespace test 135 } // namespace test
137 } // namespace app_list 136 } // namespace app_list
OLDNEW
« no previous file with comments | « ui/app_list/views/folder_header_view.cc ('k') | ui/app_list/views/page_switcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698