Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 681843002: Autofill - improve Macy's and Best Buy checkout by parsing input type="tel" (Closed)

Created:
6 years, 1 month ago by Evan Stade
Modified:
6 years, 1 month ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Autofill - improve Macy's and Best Buy checkout by parsing input type="tel" for CVC and PAN fields. BUG=427103, 427012 Committed: https://crrev.com/1dbde9ea5189edab5d9add91545de55ce540e5e3 Cr-Commit-Position: refs/heads/master@{#301508}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M chrome/test/data/autofill/heuristics/output/21_checkout_m_bestbuy.com.out View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/test/data/autofill/heuristics/output/21_checkout_m_macys.com.out View 1 chunk +5 lines, -5 lines 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Evan Stade
6 years, 1 month ago (2014-10-27 18:58:57 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years, 1 month ago (2014-10-27 21:23:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681843002/1
6 years, 1 month ago (2014-10-27 21:34:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-28 00:19:12 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-28 00:19:52 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1dbde9ea5189edab5d9add91545de55ce540e5e3
Cr-Commit-Position: refs/heads/master@{#301508}

Powered by Google App Engine
This is Rietveld 408576698