chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc - Issue 681823004: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

Issue 681823004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc ('k') | chrome/browser/ui/website_settings/website_settings_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

diff --git a/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc b/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

index 931a7e06a6357aadeab77c0dc7a9934acca8bcaa..efa8e7fd47c8175c8ab5adfc1ffe637da35ee6e4 100644

--- a/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

+++ b/chrome/browser/ui/website_settings/permission_bubble_manager_unittest.cc

@@ -64,9 +64,9 @@ class PermissionBubbleManagerTest : public ChromeRenderViewHostTestHarness {

GURL("http://www.google.com/some/url")),

iframe_request_other_domain_("iframe",

GURL("http://www.youtube.com")) {}

- virtual ~PermissionBubbleManagerTest() {}

+ ~PermissionBubbleManagerTest() override {}

- virtual void SetUp() override {

+ void SetUp() override {

ChromeRenderViewHostTestHarness::SetUp();

SetContents(CreateTestWebContents());

NavigateAndCommit(GURL("http://www.google.com"));

@@ -74,7 +74,7 @@ class PermissionBubbleManagerTest : public ChromeRenderViewHostTestHarness {

manager_.reset(new PermissionBubbleManager(web_contents()));

}

- virtual void TearDown() override {

+ void TearDown() override {

manager_.reset();

ChromeRenderViewHostTestHarness::TearDown();

}