chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc - Issue 681823004: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

Issue 681823004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/panels/panel_resize_browsertest.cc ('k') | chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

diff --git a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

index b5ee97a9dbe590ce03143a931bbbceb078cd3374..301d3717e17dc47743ef225ec3e72056f5246876 100644

--- a/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

+++ b/chrome/browser/ui/passwords/manage_passwords_bubble_model_unittest.cc

@@ -25,7 +25,7 @@ class ManagePasswordsBubbleModelTest : public testing::Test {

content::WebContentsTester::CreateTestWebContents(&profile_,

NULL)) {}

- virtual void SetUp() override {

+ void SetUp() override {

// Create the test UIController here so that it's bound to

// |test_web_contents_| and therefore accessible to the model.

new ManagePasswordsUIControllerMock(test_web_contents_.get());

@@ -33,7 +33,7 @@ class ManagePasswordsBubbleModelTest : public testing::Test {

model_.reset(new ManagePasswordsBubbleModel(test_web_contents_.get()));

}

- virtual void TearDown() override { model_.reset(); }

+ void TearDown() override { model_.reset(); }

void PretendPasswordWaiting() {

model_->set_state(password_manager::ui::PENDING_PASSWORD_AND_BUBBLE_STATE);