Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2885)

Unified Diff: chrome/browser/ui/app_list/search/history_unittest.cc

Issue 681823004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/search/history_unittest.cc
diff --git a/chrome/browser/ui/app_list/search/history_unittest.cc b/chrome/browser/ui/app_list/search/history_unittest.cc
index 349b3453cb563a314ec86a7aa37cdb8b04e6fa97..95462157a8e203d36780cd1725407a545dbe069a 100644
--- a/chrome/browser/ui/app_list/search/history_unittest.cc
+++ b/chrome/browser/ui/app_list/search/history_unittest.cc
@@ -33,7 +33,7 @@ const size_t kMaxSecondary = 2;
class HistoryDataLoadWaiter : public HistoryDataObserver {
public:
explicit HistoryDataLoadWaiter(HistoryData* data) : data_(data) {}
- virtual ~HistoryDataLoadWaiter() {}
+ ~HistoryDataLoadWaiter() override {}
void Wait() {
data_->AddObserver(this);
@@ -46,9 +46,7 @@ class HistoryDataLoadWaiter : public HistoryDataObserver {
private:
// HistoryDataObserver overrides:
- virtual void OnHistoryDataLoadedFromStore() override {
- run_loop_->Quit();
- }
+ void OnHistoryDataLoadedFromStore() override { run_loop_->Quit(); }
HistoryData* data_; // Not owned.
scoped_ptr<base::RunLoop> run_loop_;
@@ -89,17 +87,15 @@ class StoreFlushWaiter {
class SearchHistoryTest : public testing::Test {
public:
SearchHistoryTest() {}
- virtual ~SearchHistoryTest() {}
+ ~SearchHistoryTest() override {}
// testing::Test overrides:
- virtual void SetUp() override {
+ void SetUp() override {
worker_pool_ = new base::SequencedWorkerPool(1, "AppLauncherTest");
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
CreateHistory();
}
- virtual void TearDown() override {
- Flush();
- }
+ void TearDown() override { Flush(); }
void CreateHistory() {
const char kStoreDataFileName[] = "app-launcher-test";

Powered by Google App Engine
This is Rietveld 408576698