chrome/browser/ui/app_list/app_list_service_views.h - Issue 681823004: Standardize usage of virtual/override/final specifiers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/app_list_service_views.h

Issue 681823004: Standardize usage of virtual/override/final specifiers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_unittest.cc ('k') | chrome/browser/ui/app_list/app_list_shower_views_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/app_list_service_views.h

diff --git a/chrome/browser/ui/app_list/app_list_service_views.h b/chrome/browser/ui/app_list/app_list_service_views.h

index 258e8239eca267ea0181d501b92a1eb73798b7bf..7268ccffeee939b30105903f97c291de8c73b3ca 100644

--- a/chrome/browser/ui/app_list/app_list_service_views.h

+++ b/chrome/browser/ui/app_list/app_list_service_views.h

@@ -18,7 +18,7 @@ class AppListServiceViews : public AppListServiceImpl,

public:

explicit AppListServiceViews(

scoped_ptr<AppListControllerDelegate> controller_delegate);

- virtual ~AppListServiceViews();

+ ~AppListServiceViews() override;

// Set |can_dismiss| to prevent the app list dismissing when losing focus. For

// example, while showing a window-modal dialog.

@@ -31,20 +31,20 @@ class AppListServiceViews : public AppListServiceImpl,

virtual void OnViewBeingDestroyed();

// AppListService overrides:

- virtual void Init(Profile* initial_profile) override;

- virtual void ShowForProfile(Profile* requested_profile) override;

- virtual void DismissAppList() override;

- virtual bool IsAppListVisible() const override;

- virtual gfx::NativeWindow GetAppListWindow() override;

- virtual Profile* GetCurrentAppListProfile() override;

- virtual AppListControllerDelegate* GetControllerDelegate() override;

+ void Init(Profile* initial_profile) override;

+ void ShowForProfile(Profile* requested_profile) override;

+ void DismissAppList() override;

+ bool IsAppListVisible() const override;

+ gfx::NativeWindow GetAppListWindow() override;

+ Profile* GetCurrentAppListProfile() override;

+ AppListControllerDelegate* GetControllerDelegate() override;

// AppListServiceImpl overrides:

- virtual void CreateForProfile(Profile* requested_profile) override;

- virtual void DestroyAppList() override;

+ void CreateForProfile(Profile* requested_profile) override;

+ void DestroyAppList() override;

// AppListShowerDelegate overrides:

- virtual AppListViewDelegate* GetViewDelegateForCreate() override;

+ AppListViewDelegate* GetViewDelegateForCreate() override;

private:

// Responsible for creating the app list and responding to profile changes.