Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 681823003: Match language tags by prefix on Android. (Closed)

Created:
6 years, 1 month ago by bungeman-skia
Modified:
6 years, 1 month ago
Reviewers:
djsollen, tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Match language tags by prefix on Android. A request for 'zh' should match 'zh-Hans' and 'zh-Hant'. Committed: https://skia.googlesource.com/skia/+/5f6094a1eb9bf5bb9fd17ada84a5763de2853eff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/ports/SkFontMgr_android.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
bungeman-skia
6 years, 1 month ago (2014-10-27 18:30:02 UTC) #2
djsollen
lgtm
6 years, 1 month ago (2014-10-27 18:40:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681823003/1
6 years, 1 month ago (2014-10-27 18:43:42 UTC) #5
tomhudson
We never want to make it symmetric? (!langTag.startsWith(face->fLang.getTag().c_str())
6 years, 1 month ago (2014-10-27 18:46:39 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 18:52:04 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 5f6094a1eb9bf5bb9fd17ada84a5763de2853eff

Powered by Google App Engine
This is Rietveld 408576698