Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1036)

Issue 681813002: Re-enable WebUIMojoTest.EndToEndPing (Closed)

Created:
6 years, 1 month ago by yzshen1
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Re-enable WebUIMojoTest.EndToEndPing BUG=418019 TEST=None Committed: https://crrev.com/51bf9cc8d1b6a330db9b9e97001b81d704bea93a Cr-Commit-Position: refs/heads/master@{#301396}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M content/browser/webui/web_ui_mojo_browsertest.cc View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yzshen1
Hi, Scott. Please take a look. Thanks! The issue causing the failure was fixed (hopefully): ...
6 years, 1 month ago (2014-10-27 16:27:02 UTC) #2
sky
LGTM
6 years, 1 month ago (2014-10-27 16:35:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681813002/1
6 years, 1 month ago (2014-10-27 16:46:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 18:00:41 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 18:01:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51bf9cc8d1b6a330db9b9e97001b81d704bea93a
Cr-Commit-Position: refs/heads/master@{#301396}

Powered by Google App Engine
This is Rietveld 408576698