Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 681783004: Implement the PageNotificationDelegate for the new Web Notification path. (Closed)

Created:
6 years, 1 month ago by Peter Beverloo
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Implement the PageNotificationDelegate for the new Web Notification path. The PageNotificationDelegate will proxy events from the Notification sub- system to the Web Notification object in Blink for notification whose lifetime is tied to that of the page. This patch also moves the NotificationMessageFilter to a new directory in //content/browser/, as there will be new files when Service Worker integration is being added in the near future. BUG=392187 Committed: https://crrev.com/3a3284ece57af5173175a44697df6c6d5c25c989 Cr-Commit-Position: refs/heads/master@{#301974}

Patch Set 1 #

Patch Set 2 : s/DCHECK/if/ #

Total comments: 8

Patch Set 3 : address comments #

Patch Set 4 : s/Ids/ids/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -129 lines) Patch
D content/browser/notification_message_filter.h View 1 chunk +0 lines, -45 lines 0 comments Download
D content/browser/notification_message_filter.cc View 1 chunk +0 lines, -65 lines 0 comments Download
A + content/browser/notifications/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/notifications/notification_message_filter.h View 1 2 3 4 chunks +19 lines, -6 lines 0 comments Download
A + content/browser/notifications/notification_message_filter.cc View 1 2 chunks +31 lines, -7 lines 0 comments Download
A content/browser/notifications/page_notification_delegate.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A content/browser/notifications/page_notification_delegate.cc View 1 chunk +56 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 2 3 chunks +9 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 2 2 chunks +7 lines, -3 lines 0 comments Download
M content/child/notifications/notification_manager.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/child/notifications/notification_manager.cc View 1 chunk +43 lines, -2 lines 0 comments Download
M content/common/platform_notification_messages.h View 1 chunk +16 lines, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Peter Beverloo
+mkwst and jam
6 years, 1 month ago (2014-10-27 20:51:12 UTC) #2
Peter Beverloo
mkwst: friendly ping (let me know if you're busy so I can find another reviewer).
6 years, 1 month ago (2014-10-29 14:00:34 UTC) #3
Mike West
On 2014/10/29 14:00:34, Peter Beverloo wrote: > mkwst: friendly ping (let me know if you're ...
6 years, 1 month ago (2014-10-29 15:19:54 UTC) #4
Peter Beverloo
No worries, enjoy your weekend!! :-). +mvanouwerkerk
6 years, 1 month ago (2014-10-29 15:22:28 UTC) #6
Michael van Ouwerkerk
lgtm
6 years, 1 month ago (2014-10-29 16:01:21 UTC) #7
jam
rerouting to Avi
6 years, 1 month ago (2014-10-29 20:05:57 UTC) #9
Avi (use Gerrit)
LGTM with comment fixes. https://codereview.chromium.org/681783004/diff/20001/content/browser/notifications/OWNERS File content/browser/notifications/OWNERS (right): https://codereview.chromium.org/681783004/diff/20001/content/browser/notifications/OWNERS#newcode1 content/browser/notifications/OWNERS:1: peter@chromium.org For your sake :) ...
6 years, 1 month ago (2014-10-29 20:25:52 UTC) #10
Peter Beverloo
Thanks for your quick review Avi! :-) Putting this on the queue. I'll follow up ...
6 years, 1 month ago (2014-10-29 21:15:18 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681783004/60001
6 years, 1 month ago (2014-10-29 21:17:01 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-29 23:25:16 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 23:26:09 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/3a3284ece57af5173175a44697df6c6d5c25c989
Cr-Commit-Position: refs/heads/master@{#301974}

Powered by Google App Engine
This is Rietveld 408576698