src/IceInstX8632.h - Issue 681783002: Subzero: Refactor newline emission for Inst::emit().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX8632.h

Issue 681783002: Subzero: Refactor newline emission for Inst::emit(). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstX8632.h

diff --git a/src/IceInstX8632.h b/src/IceInstX8632.h

index 177843705355b9660a574fb233a0255d22929705..21a95ba2cf077a00c6ca26ef6ae3e809763adb72 100644

--- a/src/IceInstX8632.h

+++ b/src/IceInstX8632.h

@@ -464,7 +464,6 @@ public:

assert(getSrcSize() == 1);

Str << "\t" << Opcode << "\t";

getSrc(0)->emit(Func);

- Str << "\n";

}

void emitIAS(const Cfg *Func) const override {

assert(getSrcSize() == 1);

@@ -515,7 +514,6 @@ public:

getDest()->emit(Func);

Str << ", ";

getSrc(0)->emit(Func);

- Str << "\n";

}

void emitIAS(const Cfg *Func) const override {

assert(getSrcSize() == 1);

@@ -563,7 +561,6 @@ public:

getDest()->emit(Func);

Str << ", ";

getSrc(0)->emit(Func);

- Str << "\n";

}

void emitIAS(const Cfg *Func) const override {

Type Ty = getDest()->getType();

@@ -784,7 +781,6 @@ public:

getSrc(1)->emit(Func);

Str << ", ";

getSrc(2)->emit(Func);

- Str << "\n";

}

void emitIAS(const Cfg *Func) const override;

void dump(const Cfg *Func) const override {

@@ -827,7 +823,6 @@ public:

getSrc(0)->emit(Func);

Str << ", ";

getSrc(1)->emit(Func);

- Str << "\n";

}

void emitIAS(const Cfg *Func) const override;

void dump(const Cfg *Func) const override {

« no previous file with comments | « src/IceInst.cpp ('k') | src/IceInstX8632.cpp » ('j') | no next file with comments »