Issue 681783002: Subzero: Refactor newline emission for Inst::emit().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 681783002: Subzero: Refactor newline emission for Inst::emit(). (Closed)

Created:
6 years, 1 month ago by Jim Stichnoth

Modified:
6 years, 1 month ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Refactor newline emission for Inst::emit(). The (final) newline is emitted by the caller of emit(), instead of by all the emit() implementations. This sets the stage for being able to add useful comments to the textual asm, such as annotating which registers became free after the instruction. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=120b4121c313ee7faf8095c3b52998f447e2061e

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -59 lines)			Patch
M	src/IceCfgNode.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/IceInst.cpp	View	3 chunks	+0 lines, -3 lines	0 comments	Download
M	src/IceInstX8632.h	View	5 chunks	+0 lines, -5 lines	0 comments	Download
M	src/IceInstX8632.cpp	View	44 chunks	+18 lines, -51 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

6 years, 1 month ago (2014-10-27 16:51:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
120b4121c313ee7faf8095c3b52998f447e2061e (presubmit successful).