Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 681773002: mac: Avoid PlatformFontMac log spam. (Closed)

Created:
6 years, 1 month ago by Daniel Erat
Modified:
6 years, 1 month ago
Reviewers:
msw, ckocagil
CC:
chromium-reviews, Ryan Hamilton
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mac: Avoid PlatformFontMac log spam. Update PlatformFontMac to call the mac implementation of FontRenderParams. BUG=427319 Committed: https://crrev.com/07813d33da008b90a2046bcc3ae6c6c4d06effb0 Cr-Commit-Position: refs/heads/master@{#301412}

Patch Set 1 #

Patch Set 2 : whoops, add namespace to GetFontRenderParams() call #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -10 lines) Patch
M ui/gfx/platform_font_mac.h View 3 chunks +6 lines, -2 lines 0 comments Download
M ui/gfx/platform_font_mac.mm View 1 6 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Daniel Erat
6 years, 1 month ago (2014-10-27 15:05:26 UTC) #2
ckocagil
lgtm
6 years, 1 month ago (2014-10-27 15:53:51 UTC) #3
msw
lgtm
6 years, 1 month ago (2014-10-27 17:36:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681773002/20001
6 years, 1 month ago (2014-10-27 18:46:01 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-27 19:34:06 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 19:35:01 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/07813d33da008b90a2046bcc3ae6c6c4d06effb0
Cr-Commit-Position: refs/heads/master@{#301412}

Powered by Google App Engine
This is Rietveld 408576698