Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.h

Issue 681763003: Add input latency histograms for wheel events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More cleanup Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_widget_host_impl.h
diff --git a/content/browser/renderer_host/render_widget_host_impl.h b/content/browser/renderer_host/render_widget_host_impl.h
index 41df865165ec7b2313b939a62ae5f774dd3edc8f..8d86da8b8712908f7dc4d85e283489fa27427fd2 100644
--- a/content/browser/renderer_host/render_widget_host_impl.h
+++ b/content/browser/renderer_host/render_widget_host_impl.h
@@ -437,7 +437,6 @@ class CONTENT_EXPORT RenderWidgetHostImpl
// other way around.
bool should_auto_resize() { return should_auto_resize_; }
- void ComputeTouchLatency(const ui::LatencyInfo& latency_info);
void FrameSwapped(const ui::LatencyInfo& latency_info);
void DidReceiveRendererFrame();
@@ -483,11 +482,14 @@ class CONTENT_EXPORT RenderWidgetHostImpl
// Create a LatencyInfo struct with INPUT_EVENT_LATENCY_RWH_COMPONENT
// component if it is not already in |original|. And if |original| is
// not NULL, it is also merged into the resulting LatencyInfo.
- ui::LatencyInfo CreateRWHLatencyInfoIfNotExist(
+ ui::LatencyInfo CreateInputEventLatencyInfoIfNotExist(
Yufeng Shen (Slow to review) 2014/10/28 18:02:25 why do you need to change the name ?
ccameron 2014/10/28 23:18:28 It relates to input, and that wasn't in the name.
const ui::LatencyInfo* original,
blink::WebInputEvent::Type type,
const ui::LatencyInfo::InputCoordinate* logical_coordinates,
size_t logical_coordinates_size);
+ void ComputeInputLatencyHistograms(
jdduke (slow) 2014/10/29 01:47:37 Could be wrong, but I don't think this needs to be
ccameron 2014/10/29 02:09:02 It calls to GetLatencyComponentId, which is a memb
jdduke (slow) 2014/10/29 02:18:37 Could you pass GetLatencyComponentId() to the func
ccameron 2014/10/29 03:29:41 I've marked this function const, to indicate that
+ const std::string& event_type_name,
+ const ui::LatencyInfo& latency_info);
// Called when we receive a notification indicating that the renderer
// process has gone. This will reset our state so that our state will be
« no previous file with comments | « no previous file | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698