Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 681753002: Avoid possible recursion during supervised user sign in (Closed)

Created:
6 years, 1 month ago by Denis Kuznetsov (DE-MUC)
Modified:
6 years, 1 month ago
Reviewers:
Nikita (slow)
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Avoid possible recursion BUG=426522 R=nkostylev@chromium.org Committed: https://crrev.com/cdd56a8f6766469931b7c3b8a9184ef40974a833 Cr-Commit-Position: refs/heads/master@{#301357}

Patch Set 1 #

Patch Set 2 : address comments #

Total comments: 1

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M chromeos/login/auth/login_performer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chromeos/login/auth/login_performer.cc View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Denis Kuznetsov (DE-MUC)
6 years, 1 month ago (2014-10-27 13:10:39 UTC) #1
Nikita (slow)
lgtm https://codereview.chromium.org/681753002/diff/20001/chromeos/login/auth/login_performer.cc File chromeos/login/auth/login_performer.cc (right): https://codereview.chromium.org/681753002/diff/20001/chromeos/login/auth/login_performer.cc#newcode145 chromeos/login/auth/login_performer.cc:145: DoPerformLogin(user_context, auth_mode); nit: use user_context_ here too for ...
6 years, 1 month ago (2014-10-27 13:21:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681753002/40001
6 years, 1 month ago (2014-10-27 13:24:23 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-27 14:06:08 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 14:06:58 UTC) #6
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/cdd56a8f6766469931b7c3b8a9184ef40974a833
Cr-Commit-Position: refs/heads/master@{#301357}

Powered by Google App Engine
This is Rietveld 408576698