Issue 681743002: Make all references from root shortcuts (except one to GC roots)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 681743002: Make all references from root shortcuts (except one to GC roots) (Closed)

Created:
6 years, 1 month ago by yurys

Modified:
6 years, 1 month ago

Reviewers:
Yang, loislo

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Make all references from root shortcuts (except one to GC roots) Eventually we are going to nuke this shortcuts from root entry altogether. This fix makes (GC roots) retained size equal to the snapshot's total size. BUG=chromium:414190 LOG=N R=loislo@chromium.org, yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24902

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	src/heap-snapshot-generator.cc	View	1	1 chunk	+2 lines, -4 lines	0 comments	Download

Total messages: 7 (2 generated)

Yang

On 2014/10/27 11:49:40, yurys wrote: > Yang, OWNER's stamp is needed. lgtm (rubberstamp)

6 years, 1 month ago (2014-10-27 11:55:21 UTC) #6

yurys

6 years, 1 month ago (2014-10-27 12:10:28 UTC) #7

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 24902 (presubmit successful).