content/browser/child_process_launcher.cc - Issue 681733003: Removed the ProcessHandle from the RendererClosedDetails payload

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/child_process_launcher.cc

Issue 681733003: Removed the ProcessHandle from the RendererClosedDetails payload (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed mac issues Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/child_process_launcher.cc

diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc

index e47bebc3bdfc59461761f9cc99f683afa62f3832..cbe6a616945db027149c569f0cd9f668d19ce3c2 100644

--- a/content/browser/child_process_launcher.cc

+++ b/content/browser/child_process_launcher.cc

@@ -4,6 +4,7 @@

#include "content/browser/child_process_launcher.h"

+#include <string>

Charlie Reis 2014/11/10 19:57:25 Is this necessary?

sramajay 2014/11/11 14:16:05 Done.

#include <utility> // For std::pair.

#include "base/bind.h"

@@ -319,7 +320,7 @@ class ChildProcessLauncher::Context

}

if (launched)

- broker->AddPlaceholderForPid(handle);

+ broker->AddPlaceholderForPid(handle, child_process_id);

// After updating the broker, release the lock and let the child's

// messasge be processed on the broker's thread.

« no previous file with comments | « no previous file | content/browser/frame_host/render_frame_host_manager_unittest.cc » ('j') | content/browser/mach_broker_mac.mm » ('J')