Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 681733003: Removed the ProcessHandle from the RendererClosedDetails payload (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Represents the browser side of the browser <--> renderer communication 5 // Represents the browser side of the browser <--> renderer communication
6 // channel. There will be one RenderProcessHost per renderer process. 6 // channel. There will be one RenderProcessHost per renderer process.
7 7
8 #include "content/browser/renderer_host/render_process_host_impl.h" 8 #include "content/browser/renderer_host/render_process_host_impl.h"
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 1899 matching lines...) Expand 10 before | Expand all | Expand 10 after
1910 1910
1911 // child_process_launcher_ can be NULL in single process mode or if fast 1911 // child_process_launcher_ can be NULL in single process mode or if fast
1912 // termination happened. 1912 // termination happened.
1913 int exit_code = 0; 1913 int exit_code = 0;
1914 base::TerminationStatus status = 1914 base::TerminationStatus status =
1915 child_process_launcher_.get() ? 1915 child_process_launcher_.get() ?
1916 child_process_launcher_->GetChildTerminationStatus(already_dead, 1916 child_process_launcher_->GetChildTerminationStatus(already_dead,
1917 &exit_code) : 1917 &exit_code) :
1918 base::TERMINATION_STATUS_NORMAL_TERMINATION; 1918 base::TERMINATION_STATUS_NORMAL_TERMINATION;
1919 1919
1920 RendererClosedDetails details(GetHandle(), status, exit_code); 1920 RendererClosedDetails details(status, exit_code);
1921 mojo_application_host_->WillDestroySoon(); 1921 mojo_application_host_->WillDestroySoon();
1922 1922
1923 child_process_launcher_.reset(); 1923 child_process_launcher_.reset();
1924 channel_.reset(); 1924 channel_.reset();
1925 1925
1926 within_process_died_observer_ = true; 1926 within_process_died_observer_ = true;
1927 NotificationService::current()->Notify( 1927 NotificationService::current()->Notify(
1928 NOTIFICATION_RENDERER_PROCESS_CLOSED, 1928 NOTIFICATION_RENDERER_PROCESS_CLOSED,
1929 Source<RenderProcessHost>(this), 1929 Source<RenderProcessHost>(this),
1930 Details<RendererClosedDetails>(&details)); 1930 Details<RendererClosedDetails>(&details));
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
2247 2247
2248 void RenderProcessHostImpl::DecrementWorkerRefCount() { 2248 void RenderProcessHostImpl::DecrementWorkerRefCount() {
2249 DCHECK_CURRENTLY_ON(BrowserThread::UI); 2249 DCHECK_CURRENTLY_ON(BrowserThread::UI);
2250 DCHECK_GT(worker_ref_count_, 0); 2250 DCHECK_GT(worker_ref_count_, 0);
2251 --worker_ref_count_; 2251 --worker_ref_count_;
2252 if (worker_ref_count_ == 0) 2252 if (worker_ref_count_ == 0)
2253 Cleanup(); 2253 Cleanup();
2254 } 2254 }
2255 2255
2256 } // namespace content 2256 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/mach_broker_mac_unittest.cc ('k') | content/public/browser/render_process_host.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698