Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Side by Side Diff: content/browser/mach_broker_mac_unittest.cc

Issue 681733003: Removed the ProcessHandle from the RendererClosedDetails payload (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/mach_broker_mac.h" 5 #include "content/browser/mach_broker_mac.h"
6 6
7 #include "base/synchronization/lock.h" 7 #include "base/synchronization/lock.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 9
10 namespace content { 10 namespace content {
11 11
12 class MachBrokerTest : public testing::Test { 12 class MachBrokerTest : public testing::Test {
13 public: 13 public:
14 // Helper function to acquire/release locks and call |PlaceholderForPid()|. 14 // Helper function to acquire/release locks and call |PlaceholderForPid()|.
15 void AddPlaceholderForPid(base::ProcessHandle pid) { 15 void AddPlaceholderForPid(base::ProcessHandle pid, int child_process_id) {
16 base::AutoLock lock(broker_.GetLock()); 16 base::AutoLock lock(broker_.GetLock());
17 broker_.AddPlaceholderForPid(pid); 17 broker_.AddPlaceholderForPid(pid, child_process_id);
18 } 18 }
19 19
20 void InvalidatePid(base::ProcessHandle pid) { 20 void InvalidateChildProcessId(int child_process_id) {
21 broker_.InvalidatePid(pid); 21 broker_.InvalidateChildProcessId(child_process_id);
22 }
23
24 int GetChildProcessCount(int child_process_id) {
25 return broker_.child_process_id_map_.count(child_process_id);
22 } 26 }
23 27
24 // Helper function to acquire/release locks and call |FinalizePid()|. 28 // Helper function to acquire/release locks and call |FinalizePid()|.
25 void FinalizePid(base::ProcessHandle pid, 29 void FinalizePid(base::ProcessHandle pid,
26 mach_port_t task_port) { 30 mach_port_t task_port) {
27 base::AutoLock lock(broker_.GetLock()); 31 base::AutoLock lock(broker_.GetLock());
28 broker_.FinalizePid(pid, task_port); 32 broker_.FinalizePid(pid, task_port);
29 } 33 }
30 34
31 protected: 35 protected:
32 MachBroker broker_; 36 MachBroker broker_;
33 }; 37 };
34 38
35 TEST_F(MachBrokerTest, Locks) { 39 TEST_F(MachBrokerTest, Locks) {
36 // Acquire and release the locks. Nothing bad should happen. 40 // Acquire and release the locks. Nothing bad should happen.
37 base::AutoLock lock(broker_.GetLock()); 41 base::AutoLock lock(broker_.GetLock());
38 } 42 }
39 43
40 TEST_F(MachBrokerTest, AddPlaceholderAndFinalize) { 44 TEST_F(MachBrokerTest, AddPlaceholderAndFinalize) {
41 // Add a placeholder for PID 1. 45 // Add a placeholder for PID 1.
42 AddPlaceholderForPid(1); 46 AddPlaceholderForPid(1, 1);
43 EXPECT_EQ(0u, broker_.TaskForPid(1)); 47 EXPECT_EQ(0u, broker_.TaskForPid(1));
44 48
45 // Finalize PID 1. 49 // Finalize PID 1.
46 FinalizePid(1, 100u); 50 FinalizePid(1, 100u);
47 EXPECT_EQ(100u, broker_.TaskForPid(1)); 51 EXPECT_EQ(100u, broker_.TaskForPid(1));
48 52
49 // Should be no entry for PID 2. 53 // Should be no entry for PID 2.
50 EXPECT_EQ(0u, broker_.TaskForPid(2)); 54 EXPECT_EQ(0u, broker_.TaskForPid(2));
51 } 55 }
52 56
53 TEST_F(MachBrokerTest, Invalidate) { 57 TEST_F(MachBrokerTest, InvalidateChildProcessId) {
54 AddPlaceholderForPid(1); 58 // Add a placeholder for PID 1 and child process id 50.
59 AddPlaceholderForPid(1, 50);
55 FinalizePid(1, 100u); 60 FinalizePid(1, 100u);
56 61
57 EXPECT_EQ(100u, broker_.TaskForPid(1)); 62 EXPECT_EQ(100u, broker_.TaskForPid(1));
58 InvalidatePid(1u); 63 InvalidateChildProcessId(50);
59 EXPECT_EQ(0u, broker_.TaskForPid(1)); 64 EXPECT_EQ(0u, broker_.TaskForPid(1));
60 } 65 }
61 66
67 TEST_F(MachBrokerTest, ValidateChildProcessIdMap) {
68 // Add a placeholder for PID 1 and child process id 50.
69 AddPlaceholderForPid(1, 50);
70 FinalizePid(1, 100u);
71
72 EXPECT_EQ(1, GetChildProcessCount(50));
73 InvalidateChildProcessId(50);
74 EXPECT_EQ(0, GetChildProcessCount(50));
75 }
76
62 TEST_F(MachBrokerTest, FinalizeUnknownPid) { 77 TEST_F(MachBrokerTest, FinalizeUnknownPid) {
63 // Finalizing an entry for an unknown pid should not add it to the map. 78 // Finalizing an entry for an unknown pid should not add it to the map.
64 FinalizePid(1u, 100u); 79 FinalizePid(1u, 100u);
65 EXPECT_EQ(0u, broker_.TaskForPid(1u)); 80 EXPECT_EQ(0u, broker_.TaskForPid(1u));
66 } 81 }
67 82
68 } // namespace content 83 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/mach_broker_mac.mm ('k') | content/browser/renderer_host/render_process_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698