Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Side by Side Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 681733003: Removed the ProcessHandle from the RendererClosedDetails payload (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Used range-based loop Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Represents the browser side of the browser <--> renderer communication 5 // Represents the browser side of the browser <--> renderer communication
6 // channel. There will be one RenderProcessHost per renderer process. 6 // channel. There will be one RenderProcessHost per renderer process.
7 7
8 #include "content/browser/renderer_host/render_process_host_impl.h" 8 #include "content/browser/renderer_host/render_process_host_impl.h"
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 1889 matching lines...) Expand 10 before | Expand all | Expand 10 after
1900 1900
1901 // child_process_launcher_ can be NULL in single process mode or if fast 1901 // child_process_launcher_ can be NULL in single process mode or if fast
1902 // termination happened. 1902 // termination happened.
1903 int exit_code = 0; 1903 int exit_code = 0;
1904 base::TerminationStatus status = 1904 base::TerminationStatus status =
1905 child_process_launcher_.get() ? 1905 child_process_launcher_.get() ?
1906 child_process_launcher_->GetChildTerminationStatus(already_dead, 1906 child_process_launcher_->GetChildTerminationStatus(already_dead,
1907 &exit_code) : 1907 &exit_code) :
1908 base::TERMINATION_STATUS_NORMAL_TERMINATION; 1908 base::TERMINATION_STATUS_NORMAL_TERMINATION;
1909 1909
1910 RendererClosedDetails details(GetHandle(), status, exit_code); 1910 RendererClosedDetails details(status, exit_code);
1911 mojo_application_host_->WillDestroySoon(); 1911 mojo_application_host_->WillDestroySoon();
1912 1912
1913 child_process_launcher_.reset(); 1913 child_process_launcher_.reset();
1914 channel_.reset(); 1914 channel_.reset();
1915 1915
1916 within_process_died_observer_ = true; 1916 within_process_died_observer_ = true;
1917 NotificationService::current()->Notify( 1917 NotificationService::current()->Notify(
1918 NOTIFICATION_RENDERER_PROCESS_CLOSED, 1918 NOTIFICATION_RENDERER_PROCESS_CLOSED,
1919 Source<RenderProcessHost>(this), 1919 Source<RenderProcessHost>(this),
1920 Details<RendererClosedDetails>(&details)); 1920 Details<RendererClosedDetails>(&details));
(...skipping 316 matching lines...) Expand 10 before | Expand all | Expand 10 after
2237 2237
2238 void RenderProcessHostImpl::DecrementWorkerRefCount() { 2238 void RenderProcessHostImpl::DecrementWorkerRefCount() {
2239 DCHECK_CURRENTLY_ON(BrowserThread::UI); 2239 DCHECK_CURRENTLY_ON(BrowserThread::UI);
2240 DCHECK_GT(worker_ref_count_, 0); 2240 DCHECK_GT(worker_ref_count_, 0);
2241 --worker_ref_count_; 2241 --worker_ref_count_;
2242 if (worker_ref_count_ == 0) 2242 if (worker_ref_count_ == 0)
2243 Cleanup(); 2243 Cleanup();
2244 } 2244 }
2245 2245
2246 } // namespace content 2246 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698