Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: chrome/browser/extensions/external_component_loader.cc

Issue 68173031: Added enhanced bookmarks extension as an external component extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/external_component_loader.cc
diff --git a/chrome/browser/extensions/external_component_loader.cc b/chrome/browser/extensions/external_component_loader.cc
index bec5d2f9e99b90529eaa13f90df9723e127d6370..15f40bf6bc78a8e4d00279b0d371ebff15d3921f 100644
--- a/chrome/browser/extensions/external_component_loader.cc
+++ b/chrome/browser/extensions/external_component_loader.cc
@@ -4,8 +4,14 @@
#include "chrome/browser/extensions/external_component_loader.h"
+#include "base/command_line.h"
+#include "base/metrics/field_trial.h"
#include "base/values.h"
+#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension_constants.h"
+#include "components/variations/variations_associated_data.h"
+#include "extensions/common/features/feature.h"
+#include "extensions/common/features/feature_provider.h"
namespace extensions {
@@ -18,6 +24,24 @@ void ExternalComponentLoader::StartLoading() {
std::string appId = extension_misc::kInAppPaymentsSupportAppId;
prefs_->SetString(appId + ".external_update_url",
extension_urls::GetWebstoreUpdateUrl().spec());
+
+ const char kFieldTrialName[] = "EnhancedBookmarks";
+ const char kFieldTrialDefaultGroupName[] = "Default";
+ std::string field_trial_group_name =
+ base::FieldTrialList::FindFullName(kFieldTrialName);
+ if (!field_trial_group_name.empty() &&
+ field_trial_group_name != kFieldTrialDefaultGroupName &&
+ !CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kDisableEnhancedBookmarks)) {
+ appId = chrome_variations::GetVariationParamValue(kFieldTrialName, "id");
+ FeatureProvider* feature_provider =
+ FeatureProvider::GetPermissionFeatures();
+ Feature* feature = feature_provider->GetFeature("metricsPrivate");
+ if (feature && feature->IsIdInWhitelist(appId)) {
+ prefs_->SetString(appId + ".external_update_url",
+ extension_urls::GetWebstoreUpdateUrl().spec());
+ }
+ }
LoadFinished();
}

Powered by Google App Engine
This is Rietveld 408576698