Added enhanced bookmarks extension as an external component extension

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <algorithm>
 #include <iterator>
 #include <map>
 #include <set>
@@ skipping 1813 matching lines @@
     SINGLE_VALUE_TYPE(views::switches::kViewsUseRectBasedTargeting)
   },
 #endif
   {
     "enable-apps-show-on-first-paint",
     IDS_FLAGS_ENABLE_APPS_SHOW_ON_FIRST_PAINT_NAME,
     IDS_FLAGS_ENABLE_APPS_SHOW_ON_FIRST_PAINT_DESCRIPTION,
     kOsDesktop,
     SINGLE_VALUE_TYPE(switches::kEnableAppsShowOnFirstPaint)
   },
+  {
+    "disable-enhanced-bookmarks",

[Yaron, 2013/11/20 01:40:05]

Seems like this would show always though. Can we restrict it to when you're in
the experiment? 

[yefimt, 2013/11/21 22:40:39]

Done.

+    IDS_FLAGS_DISABLE_ENHANCED_BOOKMARKS_NAME,
+    IDS_FLAGS_DISABLE_ENHANCED_BOOKMARKS_DESCRIPTION,
+    kOsDesktop,
+    SINGLE_VALUE_TYPE_AND_VALUE(switches::kDisableEnhancedBookmarks, "1")
+  },

[Finnur, 2013/11/20 13:55:15]

I think we should strive towards having only enable flags here because disable
flags in settings are confusing, mainly when you want to enable something:
Instead of checking 'Enable' you un-check Disable, which is a double negative.

[yefimt, 2013/11/21 22:40:39]

Done.

 };
 
 const Experiment* experiments = kExperiments;
 size_t num_experiments = arraysize(kExperiments);
 
 // Stores and encapsulates the little state that about:flags has.
 class FlagsState {
  public:
   FlagsState() : needs_restart_(false) {}
   void ConvertFlagsToSwitches(FlagsStorage* flags_storage,
@@ skipping 480 matching lines @@
 }
 
 const Experiment* GetExperiments(size_t* count) {
   *count = num_experiments;
   return experiments;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags