Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 68173029: Support full range of PreflightPolicy over WebURLLoaderOptions (Closed)

Created:
7 years, 1 month ago by sof
Modified:
7 years, 1 month ago
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Support full range of PreflightPolicy over WebURLLoaderOptions Allow users of WebURLLoader to state the preflight behavior to follow for the request. This is done so that the user/caller can explicitly control when its author header set (http://www.w3.org/TR/cors/#author-request-headers) is empty, then no preflight must be performed. This puts the responsibility on the caller to adhere to CORS and not disable preflighting when the author set is non-empty or the request is over non-simple methods (http://www.w3.org/TR/cors/#simple-method ) The WebURLLoaderOptions default is ConsiderPreflight. R=jochen BUG=173727 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162225

Patch Set 1 #

Total comments: 1

Patch Set 2 : compile-time asserts for ensuring that PreflightPolicy enums remain sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M Source/web/AssociatedURLLoader.cpp View 1 2 chunks +5 lines, -1 line 0 comments Download
M public/web/WebURLLoaderOptions.h View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
At your leisure, please have a look. For context, https://code.google.com/p/chromium/issues/detail?id=173727#c10
7 years, 1 month ago (2013-11-18 09:43:53 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/68173029/diff/1/Source/web/AssociatedURLLoader.cpp File Source/web/AssociatedURLLoader.cpp (right): https://codereview.chromium.org/68173029/diff/1/Source/web/AssociatedURLLoader.cpp#newcode311 Source/web/AssociatedURLLoader.cpp:311: COMPILE_ASSERT_MATCHING_ENUM(WebURLLoaderOptions::CrossOriginRequestPolicyAllow, AllowCrossOriginRequests); please add new enums here
7 years, 1 month ago (2013-11-18 11:59:06 UTC) #2
sof
On 2013/11/18 11:59:06, jochen wrote: > lgtm > > https://codereview.chromium.org/68173029/diff/1/Source/web/AssociatedURLLoader.cpp > File Source/web/AssociatedURLLoader.cpp (right): > ...
7 years, 1 month ago (2013-11-18 12:28:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/68173029/60001
7 years, 1 month ago (2013-11-18 18:33:33 UTC) #4
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 19:38:46 UTC) #5
Message was sent while issue was closed.
Change committed as 162225

Powered by Google App Engine
This is Rietveld 408576698