Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 68173021: Android perf tests: use a proper timer. (Closed)

Created:
7 years, 1 month ago by bulach
Modified:
7 years, 1 month ago
Reviewers:
tonyg
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

Android perf tests: use a proper timer. Rather than relying on |flush| to be called, use a timer to keep the log going. BUG= NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235338

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M build/android/pylib/perf/test_runner.py View 4 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bulach
some bots are still timing out, hopefully this will fix them.
7 years, 1 month ago (2013-11-14 16:35:25 UTC) #1
tonyg
lgtm
7 years, 1 month ago (2013-11-14 16:45:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/68173021/30001
7 years, 1 month ago (2013-11-15 09:27:39 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=225049
7 years, 1 month ago (2013-11-15 12:32:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/68173021/30001
7 years, 1 month ago (2013-11-15 13:43:25 UTC) #5
tonyg
On 2013/11/15 13:43:25, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
7 years, 1 month ago (2013-11-15 14:44:28 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=225120
7 years, 1 month ago (2013-11-15 15:20:43 UTC) #7
bulach
adding NOTRY.. looks like all failures in http://build.chromium.org/p/chromium.perf/builders/Android%20GN/builds/8926 are timeout related, so hopefully this will ...
7 years, 1 month ago (2013-11-15 15:31:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/68173021/30001
7 years, 1 month ago (2013-11-15 15:32:17 UTC) #9
commit-bot: I haz the power
7 years, 1 month ago (2013-11-15 16:08:26 UTC) #10
Message was sent while issue was closed.
Change committed as 235338

Powered by Google App Engine
This is Rietveld 408576698