Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 68173019: Remove static initializer from AppListView::SetNextPaintCallback(). (Closed)

Created:
7 years, 1 month ago by koz (OOO until 15th September)
Modified:
7 years, 1 month ago
Reviewers:
benwells
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove static initializer from AppListView::SetNextPaintCallback(). BUG=317171 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235692

Patch Set 1 #

Total comments: 7

Patch Set 2 : fix bugs #

Total comments: 4

Patch Set 3 : respond to comments #

Patch Set 4 : other nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -26 lines) Patch
M chrome/browser/ui/app_list/app_list_service.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service.cc View 1 2 3 chunks +19 lines, -6 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_disabled.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/views/app_list/win/app_list_service_win.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/app_list/views/app_list_view.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 2 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
koz (OOO until 15th September)
7 years, 1 month ago (2013-11-14 05:59:57 UTC) #1
Vadim Sh.
Hello. I did some updates on isolateserver.appspot.com, and it affected your linux_rel try job (compile ...
7 years, 1 month ago (2013-11-14 07:27:21 UTC) #2
benwells
https://codereview.chromium.org/68173019/diff/1/chrome/browser/ui/app_list/app_list_service.cc File chrome/browser/ui/app_list/app_list_service.cc (right): https://codereview.chromium.org/68173019/diff/1/chrome/browser/ui/app_list/app_list_service.cc#newcode56 chrome/browser/ui/app_list/app_list_service.cc:56: void RecordStartupInfo(StartupType startup_type, const base::Time& start_time) { What calls ...
7 years, 1 month ago (2013-11-15 02:13:58 UTC) #3
koz (OOO until 15th September)
https://codereview.chromium.org/68173019/diff/1/chrome/browser/ui/app_list/app_list_service.cc File chrome/browser/ui/app_list/app_list_service.cc (right): https://codereview.chromium.org/68173019/diff/1/chrome/browser/ui/app_list/app_list_service.cc#newcode56 chrome/browser/ui/app_list/app_list_service.cc:56: void RecordStartupInfo(StartupType startup_type, const base::Time& start_time) { On 2013/11/15 ...
7 years, 1 month ago (2013-11-17 23:16:19 UTC) #4
benwells
lgtm with nits https://codereview.chromium.org/68173019/diff/160001/chrome/browser/ui/app_list/app_list_service.cc File chrome/browser/ui/app_list/app_list_service.cc (right): https://codereview.chromium.org/68173019/diff/160001/chrome/browser/ui/app_list/app_list_service.cc#newcode8 chrome/browser/ui/app_list/app_list_service.cc:8: #include "base/callback.h" Nit: are bind.h and ...
7 years, 1 month ago (2013-11-18 05:13:31 UTC) #5
koz (OOO until 15th September)
https://codereview.chromium.org/68173019/diff/160001/chrome/browser/ui/app_list/app_list_service.cc File chrome/browser/ui/app_list/app_list_service.cc (right): https://codereview.chromium.org/68173019/diff/160001/chrome/browser/ui/app_list/app_list_service.cc#newcode8 chrome/browser/ui/app_list/app_list_service.cc:8: #include "base/callback.h" On 2013/11/18 05:13:32, benwells wrote: > Nit: ...
7 years, 1 month ago (2013-11-18 06:31:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/koz@chromium.org/68173019/240001
7 years, 1 month ago (2013-11-18 06:31:41 UTC) #7
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 11:04:36 UTC) #8
Message was sent while issue was closed.
Change committed as 235692

Powered by Google App Engine
This is Rietveld 408576698