Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: Source/bindings/v8/DOMDataStore.cpp

Issue 68173017: Have DOMDataStore::current() return a reference (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/DOMDataStore.h ('k') | Source/bindings/v8/DOMWrapperWorld.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 V8PerIsolateData::current()->registerDOMDataStore(this); 44 V8PerIsolateData::current()->registerDOMDataStore(this);
45 } 45 }
46 46
47 DOMDataStore::~DOMDataStore() 47 DOMDataStore::~DOMDataStore()
48 { 48 {
49 ASSERT(m_type != MainWorld); // We never actually destruct the main world's DOMDataStore. 49 ASSERT(m_type != MainWorld); // We never actually destruct the main world's DOMDataStore.
50 V8PerIsolateData::current()->unregisterDOMDataStore(this); 50 V8PerIsolateData::current()->unregisterDOMDataStore(this);
51 m_wrapperMap.clear(); 51 m_wrapperMap.clear();
52 } 52 }
53 53
54 DOMDataStore* DOMDataStore::mainWorldStore() 54 DOMDataStore& DOMDataStore::mainWorldStore()
55 { 55 {
56 DEFINE_STATIC_LOCAL(DOMDataStore, mainWorldDOMDataStore, (MainWorld)); 56 DEFINE_STATIC_LOCAL(DOMDataStore, mainWorldDOMDataStore, (MainWorld));
57 ASSERT(isMainThread()); 57 ASSERT(isMainThread());
58 return &mainWorldDOMDataStore; 58 return mainWorldDOMDataStore;
59 } 59 }
60 60
61 DOMDataStore* DOMDataStore::current(v8::Isolate* isolate) 61 DOMDataStore& DOMDataStore::current(v8::Isolate* isolate)
62 { 62 {
63 V8PerIsolateData* data = isolate ? V8PerIsolateData::from(isolate) : V8PerIs olateData::current(); 63 V8PerIsolateData* data = isolate ? V8PerIsolateData::from(isolate) : V8PerIs olateData::current();
64 if (UNLIKELY(!!data->workerDOMDataStore())) 64 if (UNLIKELY(!!data->workerDOMDataStore()))
65 return data->workerDOMDataStore(); 65 return *data->workerDOMDataStore();
66 66
67 if (DOMWrapperWorld::isolatedWorldsExist()) { 67 if (DOMWrapperWorld::isolatedWorldsExist()) {
68 DOMWrapperWorld* isolatedWorld = DOMWrapperWorld::isolatedWorld(v8::Cont ext::GetEntered()); 68 DOMWrapperWorld* isolatedWorld = DOMWrapperWorld::isolatedWorld(v8::Cont ext::GetEntered());
69 if (UNLIKELY(!!isolatedWorld)) 69 if (UNLIKELY(!!isolatedWorld))
70 return isolatedWorld->isolatedWorldDOMDataStore(); 70 return isolatedWorld->isolatedWorldDOMDataStore();
71 } 71 }
72 72
73 return mainWorldStore(); 73 return mainWorldStore();
74 } 74 }
75 75
76 } // namespace WebCore 76 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/bindings/v8/DOMDataStore.h ('k') | Source/bindings/v8/DOMWrapperWorld.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698