Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: chromeos/dbus/shill_service_client_unittest.cc

Issue 681723003: Add new shill client for VPN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes nit from Steven Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/shill_manager_client_unittest.cc ('k') | chromeos/dbus/shill_third_party_vpn_driver_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/shill_service_client_unittest.cc
diff --git a/chromeos/dbus/shill_service_client_unittest.cc b/chromeos/dbus/shill_service_client_unittest.cc
index 3f1df25788bc1a1ccd7cf9ead351e40f8c06c412..414adac411c16070a55c369025f1566a5ddc53b5 100644
--- a/chromeos/dbus/shill_service_client_unittest.cc
+++ b/chromeos/dbus/shill_service_client_unittest.cc
@@ -144,9 +144,12 @@ TEST_F(ShillServiceClientTest, SetProperties) {
// Set expectations.
scoped_ptr<base::DictionaryValue> arg(CreateExampleServiceProperties());
- PrepareForMethodCall(shill::kSetPropertiesFunction,
- base::Bind(&ExpectDictionaryValueArgument, arg.get()),
- response.get());
+ // Use a variant valued dictionary rather than a string valued one.
+ const bool string_valued = false;
+ PrepareForMethodCall(
+ shill::kSetPropertiesFunction,
+ base::Bind(&ExpectDictionaryValueArgument, arg.get(), string_valued),
+ response.get());
// Call method.
MockClosure mock_closure;
« no previous file with comments | « chromeos/dbus/shill_manager_client_unittest.cc ('k') | chromeos/dbus/shill_third_party_vpn_driver_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698