chromeos/dbus/shill_service_client_unittest.cc - Issue 681723003: Add new shill client for VPN

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/shill_service_client_unittest.cc

Issue 681723003: Add new shill client for VPN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated the interface to better suit the upper layer Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/dbus/shill_service_client_unittest.cc

diff --git a/chromeos/dbus/shill_service_client_unittest.cc b/chromeos/dbus/shill_service_client_unittest.cc

index 3f1df25788bc1a1ccd7cf9ead351e40f8c06c412..414adac411c16070a55c369025f1566a5ddc53b5 100644

--- a/chromeos/dbus/shill_service_client_unittest.cc

+++ b/chromeos/dbus/shill_service_client_unittest.cc

@@ -144,9 +144,12 @@ TEST_F(ShillServiceClientTest, SetProperties) {

// Set expectations.

scoped_ptr<base::DictionaryValue> arg(CreateExampleServiceProperties());

- PrepareForMethodCall(shill::kSetPropertiesFunction,

- base::Bind(&ExpectDictionaryValueArgument, arg.get()),

- response.get());

+ // Use a variant valued dictionary rather than a string valued one.

+ const bool string_valued = false;

+ PrepareForMethodCall(

+ shill::kSetPropertiesFunction,

+ base::Bind(&ExpectDictionaryValueArgument, arg.get(), string_valued),

+ response.get());

// Call method.

MockClosure mock_closure;