Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: chromeos/dbus/shill_manager_client_unittest.cc

Issue 681723003: Add new shill client for VPN (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixes review comments from Steven Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/dbus/shill_manager_client_unittest.cc
diff --git a/chromeos/dbus/shill_manager_client_unittest.cc b/chromeos/dbus/shill_manager_client_unittest.cc
index a5c6c7a3b320a4aa841b1a3e5b19354758c739f9..6ec57536d3796b7e176c09eee2b679443bfdfc17 100644
--- a/chromeos/dbus/shill_manager_client_unittest.cc
+++ b/chromeos/dbus/shill_manager_client_unittest.cc
@@ -273,10 +273,13 @@ TEST_F(ShillManagerClientTest, ConfigureService) {
writer.AppendObjectPath(object_path);
// Create the argument dictionary.
scoped_ptr<base::DictionaryValue> arg(CreateExampleServiceProperties());
+ // Use a variant valued dictionary rather than a string valued one.
+ bool string_valued = false;
stevenjb 2014/11/03 16:55:23 const bool
kaliamoorthi 2014/11/04 12:58:59 Done.
// Set expectations.
- PrepareForMethodCall(shill::kConfigureServiceFunction,
- base::Bind(&ExpectDictionaryValueArgument, arg.get()),
- response.get());
+ PrepareForMethodCall(
+ shill::kConfigureServiceFunction,
+ base::Bind(&ExpectDictionaryValueArgument, arg.get(), string_valued),
+ response.get());
// Call method.
MockErrorCallback mock_error_callback;
client_->ConfigureService(*arg,
@@ -297,10 +300,13 @@ TEST_F(ShillManagerClientTest, GetService) {
writer.AppendObjectPath(object_path);
// Create the argument dictionary.
scoped_ptr<base::DictionaryValue> arg(CreateExampleServiceProperties());
+ // Use a variant valued dictionary rather than a string valued one.
+ bool string_valued = false;
stevenjb 2014/11/03 16:55:23 const
kaliamoorthi 2014/11/04 12:58:59 Done.
// Set expectations.
- PrepareForMethodCall(shill::kGetServiceFunction,
- base::Bind(&ExpectDictionaryValueArgument, arg.get()),
- response.get());
+ PrepareForMethodCall(
+ shill::kGetServiceFunction,
+ base::Bind(&ExpectDictionaryValueArgument, arg.get(), string_valued),
+ response.get());
// Call method.
MockErrorCallback mock_error_callback;
client_->GetService(*arg,

Powered by Google App Engine
This is Rietveld 408576698