Add new shill client for VPN

chromeos/dbus/shill_third_party_vpn_observer.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_DBUS_SHILL_THIRD_PARTY_VPN_OBSERVER_H_
+#define CHROMEOS_DBUS_SHILL_THIRD_PARTY_VPN_OBSERVER_H_
+
+#include <stdint.h>
+
+namespace chromeos {
+
+// This is a base class for observers which handle signals sent by the
+// ThirdPartyVpnAdaptor in Shill.
+class ShillThirdPartyVpnObserver {
+ public:
+  ShillThirdPartyVpnObserver() {}

[pneubeck (no reviews), 2014/11/12 14:21:07]

nit:
you _could_ have dropped this constructor if you use DISALLOW_ASSIGN instead of
DISALLOW_COPY_AND_ASSIGN.
both is fine with me.

[kaliamoorthi, 2014/11/13 12:16:31]

Acknowledged.

+
+  // Ownership of |data| belongs to the caller, hence the contents should be
+  // consumed before the call returns, i.e., pointer should not be dereferenced
+  // after the function returns. The method takes raw data pointer and length
+  // instead of a type like vector to avoid additional memcpys.
+  virtual void OnPacketReceived(const uint8_t* data, size_t length) = 0;
+  virtual void OnPlatformMessage(uint32_t message) = 0;
+
+ protected:
+  virtual ~ShillThirdPartyVpnObserver() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(ShillThirdPartyVpnObserver);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_DBUS_SHILL_THIRD_PARTY_VPN_OBSERVER_H_