Add new shill client for VPN

chromeos/dbus/fake_shill_third_party_vpn_driver_client.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_DBUS_FAKE_SHILL_THIRD_PARTY_VPN_DRIVER_CLIENT_H_
+#define CHROMEOS_DBUS_FAKE_SHILL_THIRD_PARTY_VPN_DRIVER_CLIENT_H_
+
+#include "base/basictypes.h"

[pneubeck (no reviews), 2014/11/11 13:09:35]

replace basictypes.h by macros.h if you only need a DISALLOW* macro in the whole
CL.

[kaliamoorthi, 2014/11/11 14:58:32]

This was added for uint32 etc.

[pneubeck (no reviews), 2014/11/11 16:34:48]

From basictypes.h :
// DEPRECATED: Please use (u)int{8,16,32,64}_t instead (and include <stdint.h>).

[kaliamoorthi, 2014/11/11 17:49:19]

Done.

+#include "chromeos/chromeos_export.h"
+#include "chromeos/dbus/shill_third_party_vpn_driver_client.h"
+
+namespace chromeos {
+
+// A fake implementation of ShillThirdPartyVpnDriverClient.

[pneubeck (no reviews), 2014/11/11 13:09:35]

please add some documentation what fake behavior you're approximately
implementing. I think this not easy to guess for this client.

+class CHROMEOS_EXPORT FakeShillThirdPartyVpnDriverClient
+    : public ShillThirdPartyVpnDriverClient,
+      public ShillThirdPartyVpnDriverClient::TestInterface {
+ public:
+  FakeShillThirdPartyVpnDriverClient();
+  ~FakeShillThirdPartyVpnDriverClient() override;
+
+  // ShillThirdPartyVpnDriverClient overrides
+  void Init(dbus::Bus* bus) override;
+  void AddShillThirdPartyVpnObserver(
+      const dbus::ObjectPath& object_path,
+      ShillThirdPartyVpnObserver* observer) override;
+  void RemoveShillThirdPartyVpnObserver(
+      const dbus::ObjectPath& object_path) override;
+  void SetParameters(
+      const dbus::ObjectPath& object_path,
+      const base::DictionaryValue& parameters,
+      const base::Closure& callback,
+      const ShillClientHelper::ErrorCallback& error_callback) override;
+  void UpdateConnectionState(
+      const dbus::ObjectPath& object_path,
+      const uint32 connection_state,
+      const base::Closure& callback,
+      const ShillClientHelper::ErrorCallback& error_callback) override;
+  void SendPacket(
+      const dbus::ObjectPath& object_path,
+      const std::string& ip_packet,
+      const base::Closure& callback,
+      const ShillClientHelper::ErrorCallback& error_callback) override;
+  ShillThirdPartyVpnDriverClient::TestInterface* GetTestInterface() override;
+
+  // ShillThirdPartyVpnDriverClient::TestInterface overrides
+  void OnPacketReceived(const dbus::ObjectPath& object_path,
+                        const uint8* data,
+                        size_t length) override;
+  void OnPlatformMessage(const dbus::ObjectPath& object_path,
+                         uint32 message) override;
+
+ private:
+  typedef std::map<std::string, ShillThirdPartyVpnObserver*> ObserverMap;

[pneubeck (no reviews), 2014/11/11 13:09:35]

typedef -> using 
please replace typedef in the whole CL

[kaliamoorthi, 2014/11/11 14:58:32]

Done.

+
+  ObserverMap observer_map_;
+
+  DISALLOW_COPY_AND_ASSIGN(FakeShillThirdPartyVpnDriverClient);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_DBUS_FAKE_SHILL_THIRD_PARTY_VPN_DRIVER_CLIENT_H_