Add new shill client for VPN

chromeos/dbus/shill_service_client_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/values.h"
 #include "chromeos/dbus/shill_client_unittest_base.h"
 #include "chromeos/dbus/shill_service_client.h"
 #include "dbus/message.h"
 #include "dbus/object_path.h"
@@ skipping 126 matching lines @@
   // Run the message loop.
   message_loop_.RunUntilIdle();
 }
 
 TEST_F(ShillServiceClientTest, SetProperties) {
   // Create response.
   scoped_ptr<dbus::Response> response(dbus::Response::CreateEmpty());
 
   // Set expectations.
   scoped_ptr<base::DictionaryValue> arg(CreateExampleServiceProperties());
-  PrepareForMethodCall(shill::kSetPropertiesFunction,
-                       base::Bind(&ExpectDictionaryValueArgument, arg.get()),
-                       response.get());
+  // Use a variant valued dictionary rather than a string valued one.
+  bool string_valued = false;

[stevenjb, 2014/11/03 16:55:23]

const

[kaliamoorthi, 2014/11/04 12:58:59]

Done.

+  PrepareForMethodCall(
+      shill::kSetPropertiesFunction,
+      base::Bind(&ExpectDictionaryValueArgument, arg.get(), string_valued),
+      response.get());
 
   // Call method.
   MockClosure mock_closure;
   MockErrorCallback mock_error_callback;
   client_->SetProperties(dbus::ObjectPath(kExampleServicePath),
                          *arg,
                          mock_closure.GetCallback(),
                          mock_error_callback.GetCallback());
   EXPECT_CALL(mock_closure, Run()).Times(1);
   EXPECT_CALL(mock_error_callback, Run(_, _)).Times(0);
@@ skipping 135 matching lines @@
                                  mock_closure.GetCallback(),
                                  mock_error_callback.GetCallback());
   EXPECT_CALL(mock_closure, Run()).Times(1);
   EXPECT_CALL(mock_error_callback, Run(_, _)).Times(0);
 
   // Run the message loop.
   message_loop_.RunUntilIdle();
 }
 
 }  // namespace chromeos