Added debugMe method.

Added debugMe method.

BUG=426714
TEST=Open an inspector with Ctrl+Shift+J: Type fileManager.debugMe() in the console.

Sample Output:
Debug information.
1. fileManager.initializeQueue_.pendingTasks_
Length: 2
AsyncUtil.GroupTask
- name: (unnamed#8)
- dependencies:
AsyncUtil.GroupTask
- name: (unnamed#9)
- dependencies: UnexistTask1,UnexistTask2
2. VolumeManagerWrapper
VolumeManagerWrapper
- Initialized: true
- VolumeManager:
  VolumeManager
  - MountQueue_:
    AsyncUtil.ConcurrentQueue
    - WaitingTasksCount: 0
    - RunningTasksCount: 0
    - isCancelled: false
End of debug information.

Committed: https://crrev.com/0ba4af88373dea62f6a78feb76a75b02c15e4a94
Cr-Commit-Position: refs/heads/master@{#301589}

[yawano, 2014-10-27 04:05:50]

yawano@chromium.org changed reviewers:
+ mtomasz@chromium.org

[yawano, 2014-10-27 04:05:50]

Added fileManager.debugMe(). PTAL. Thanks.

[mtomasz, 2014-10-27 04:15:44]

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/common/js/async_util.js (right):

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/async_util.js:155: * @return string
String representation of the instance.
nit: {string}

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/async_util.js:197: * @return string
String representation of the instance.
ditto

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3875: * */
nit: * */ -> **/

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3877: var out =
'DebugMe output\n' +
nit: Let's be more formal:

'Debug information.\n'
...
'End of debug information.\n'

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3886: if
(this.volumeManager_) {
nit: {} not necessary for single line body.

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3889: out +=
'VolumeManager is not initialized.\n';
volumeManager_ != null doesn't really mean that the volume is not initialized.
It means that initialization started.

Can we check for state of the queue in VolumeManagerWrapper and print it?

Also, what would happen if initializing of the volume manager fails? Can we
print more debug information? What do you think?

[yawano, 2014-10-27 06:52:52]

Changed the output of VolumeManagerWrapper. PTAL. Thanks.

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/common/js/async_util.js (right):

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/async_util.js:155: * @return string
String representation of the instance.
On 2014/10/27 04:15:43, mtomasz wrote:
> nit: {string}

Done.

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/async_util.js:197: * @return string
String representation of the instance.
On 2014/10/27 04:15:43, mtomasz wrote:
> ditto

Done.

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3875: * */
On 2014/10/27 04:15:44, mtomasz wrote:
> nit: * */ -> **/

Done.

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3877: var out =
'DebugMe output\n' +
On 2014/10/27 04:15:43, mtomasz wrote:
> nit: Let's be more formal:
> 
> 'Debug information.\n'
> ...
> 'End of debug information.\n'

Done.

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3886: if
(this.volumeManager_) {
On 2014/10/27 04:15:44, mtomasz wrote:
> nit: {} not necessary for single line body.

Acknowledged.

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3889: out +=
'VolumeManager is not initialized.\n';
On 2014/10/27 04:15:44, mtomasz wrote:
> volumeManager_ != null doesn't really mean that the volume is not initialized.
> It means that initialization started.
> 
> Can we check for state of the queue in VolumeManagerWrapper and print it?
> 
> Also, what would happen if initializing of the volume manager fails? Can we
> print more debug information? What do you think?

Changed to check whether the initialization of VolumeManager is actually
completed or not.

One of the cases of failing initilization of VolumeManager is that some error
has occurred during getting VolumeMetadataList or creating VolumeInfo from it.
In these cases, pending tasks in VolumeManagerWrapper are not executed.

If initilization of VolumeManager fails, we don't have access to the instance of
VolumeManager. So we cannot obtain much information about VolumeManager instance
itself easily. However we can obtain and show information about
VolumeManagerWrapper such as pendingTasks_.

[mtomasz, 2014-10-27 08:00:36]

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3879: var keys =
Object.keys(this.initializeQueue_.pendingTasks_);
Please create a getter instead of accessing a private member of an object.

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3889: out +=
'VolumeManager is not initialized.\n';
On 2014/10/27 06:52:52, yawano wrote:
> On 2014/10/27 04:15:44, mtomasz wrote:
> > volumeManager_ != null doesn't really mean that the volume is not
initialized.
> > It means that initialization started.
> > 
> > Can we check for state of the queue in VolumeManagerWrapper and print it?
> > 
> > Also, what would happen if initializing of the volume manager fails? Can we
> > print more debug information? What do you think?
> 
> Changed to check whether the initialization of VolumeManager is actually
> completed or not.
> 
> One of the cases of failing initilization of VolumeManager is that some error
> has occurred during getting VolumeMetadataList or creating VolumeInfo from it.
> In these cases, pending tasks in VolumeManagerWrapper are not executed.
> 
> If initilization of VolumeManager fails, we don't have access to the instance
of
> VolumeManager. So we cannot obtain much information about VolumeManager
instance
> itself easily. However we can obtain and show information about
> VolumeManagerWrapper such as pendingTasks_.

We should be able to get instance of VolumeManager via.
this.backgroundPage_.VolumeManager.instance_.

https://codereview.chromium.org/681693003/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/common/js/async_util.js (right):

https://codereview.chromium.org/681693003/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/async_util.js:193: }
nit: ; missing

https://codereview.chromium.org/681693003/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/async_util.js:203: }
ditto

[yawano, 2014-10-27 09:01:13]

Thank you for the review. Changed to provide debug information of VolumeManager
even when initilization of VolumeManager has failed. PTAL. Thanks.

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
File ui/file_manager/file_manager/foreground/js/file_manager.js (right):

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3879: var keys =
Object.keys(this.initializeQueue_.pendingTasks_);
On 2014/10/27 08:00:35, mtomasz wrote:
> Please create a getter instead of accessing a private member of an object.

Done.

https://codereview.chromium.org/681693003/diff/20001/ui/file_manager/file_man...
ui/file_manager/file_manager/foreground/js/file_manager.js:3889: out +=
'VolumeManager is not initialized.\n';
On 2014/10/27 08:00:35, mtomasz wrote:
> On 2014/10/27 06:52:52, yawano wrote:
> > On 2014/10/27 04:15:44, mtomasz wrote:
> > > volumeManager_ != null doesn't really mean that the volume is not
> initialized.
> > > It means that initialization started.
> > > 
> > > Can we check for state of the queue in VolumeManagerWrapper and print it?
> > > 
> > > Also, what would happen if initializing of the volume manager fails? Can
we
> > > print more debug information? What do you think?
> > 
> > Changed to check whether the initialization of VolumeManager is actually
> > completed or not.
> > 
> > One of the cases of failing initilization of VolumeManager is that some
error
> > has occurred during getting VolumeMetadataList or creating VolumeInfo from
it.
> > In these cases, pending tasks in VolumeManagerWrapper are not executed.
> > 
> > If initilization of VolumeManager fails, we don't have access to the
instance
> of
> > VolumeManager. So we cannot obtain much information about VolumeManager
> instance
> > itself easily. However we can obtain and show information about
> > VolumeManagerWrapper such as pendingTasks_.
> 
> We should be able to get instance of VolumeManager via.
> this.backgroundPage_.VolumeManager.instance_. 

Done.

Thank you for the suggestion. I didn't come up with this idea. Changed to
provide debug information of VolumeManager even when initialization of
VolumeManager has failed.

https://codereview.chromium.org/681693003/diff/40001/ui/file_manager/file_man...
File ui/file_manager/file_manager/common/js/async_util.js (right):

https://codereview.chromium.org/681693003/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/async_util.js:193: }
On 2014/10/27 08:00:36, mtomasz wrote:
> nit: ; missing

Done.

https://codereview.chromium.org/681693003/diff/40001/ui/file_manager/file_man...
ui/file_manager/file_manager/common/js/async_util.js:203: }
On 2014/10/27 08:00:35, mtomasz wrote:
> ditto

Done.

[mtomasz, 2014-10-28 06:09:03]

Sorry for late. Basically looks good to me, with one question.

https://codereview.chromium.org/681693003/diff/60001/ui/file_manager/file_man...
File ui/file_manager/file_manager/background/js/volume_manager.js (right):

https://codereview.chromium.org/681693003/diff/60001/ui/file_manager/file_man...
ui/file_manager/file_manager/background/js/volume_manager.js:890: '  ' +
this.mountQueue_.toString().replace(/\n/g, '\n  ');
nit: What's the purpose of this regular expression?

[yawano, 2014-10-28 06:11:50]

Thank you for the review.

https://codereview.chromium.org/681693003/diff/60001/ui/file_manager/file_man...
File ui/file_manager/file_manager/background/js/volume_manager.js (right):

https://codereview.chromium.org/681693003/diff/60001/ui/file_manager/file_man...
ui/file_manager/file_manager/background/js/volume_manager.js:890: '  ' +
this.mountQueue_.toString().replace(/\n/g, '\n  ');
On 2014/10/28 06:09:03, mtomasz wrote:
> nit: What's the purpose of this regular expression?

This is for indenting with two spaces.

e.g. 
A\n
B\n
C

is replaced with

A\n
  B\n
  C

[mtomasz, 2014-10-28 06:34:07]

lgtm

[yawano, 2014-10-28 06:59:33]

The CQ bit was checked by yawano@chromium.org

[commit-bot: I haz the power, 2014-10-28 07:00:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/681693003/60001

[commit-bot: I haz the power, 2014-10-28 07:42:34]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2014-10-28 07:43:11]

Patchset 4 (id:??) landed as
https://crrev.com/0ba4af88373dea62f6a78feb76a75b02c15e4a94
Cr-Commit-Position: refs/heads/master@{#301589}