Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Unified Diff: net/base/x509_certificate_openssl.cc

Issue 6816020: Fix opensll, in follow up to http://src.chromium.org/viewvc/chrome?view=rev&revision=80778 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/x509_certificate_openssl.cc
diff --git a/net/base/x509_certificate_openssl.cc b/net/base/x509_certificate_openssl.cc
index 0d2c12e4296a68048bc28ad2e14f52c9b10f4ab5..433ca0df3f0b8e34b107c9d46dbe140a32355a27 100644
--- a/net/base/x509_certificate_openssl.cc
+++ b/net/base/x509_certificate_openssl.cc
@@ -475,6 +475,13 @@ int X509Certificate::Verify(const std::string& hostname,
if (IsCertStatusError(verify_result->cert_status))
return MapCertStatusToNetError(verify_result->cert_status);
+ // Currently we only ues OpenSSL's default root CA paths, so treat all
+ // correctly verified certs as being from a known root. TODO(joth): if the
+ // motivations described in http://src.chromium.org/viewvc/chrome?view=rev&revision=80778
+ // become an issue on OpenSSL builds, we will need to embed a hardcoded list
+ // of well known root CAs, as per the _mac and _win versions.
+ verify_result->is_issued_by_known_root = true;
+
return OK;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698