Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 681593003: Revert of Extract LoginPerformer to chromeos/auth (Closed)

Created:
6 years, 1 month ago by Nikita (slow)
Modified:
6 years, 1 month ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Extract LoginPerformer to chromeos/auth (patchset #8 id:140001 of https://codereview.chromium.org/614973002/) Reason for revert: Introduces new crashes: crbug.com/426522 Original issue's description: > Extract LoginPerformer to chromeos/auth > > BUG=387613 > R=nkostylev@chromium.org > > Committed: https://crrev.com/2ec6339f32455ab40a9ada24ee8a38e396dca9fb > Cr-Commit-Position: refs/heads/master@{#300489} TBR=antrim@chromium.org NOTREECHECKS=true NOTRY=true BUG=387613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+579 lines, -843 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_profile_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/app_mode/kiosk_profile_loader.cc View 2 chunks +1 line, -2 lines 0 comments Download
D chrome/browser/chromeos/login/auth/chrome_login_performer.h View 1 chunk +0 lines, -78 lines 0 comments Download
D chrome/browser/chromeos/login/auth/chrome_login_performer.cc View 1 chunk +0 lines, -171 lines 0 comments Download
A chrome/browser/chromeos/login/auth/login_performer.h View 1 chunk +168 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/login/auth/login_performer.cc View 1 chunk +372 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 5 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/lock/screen_locker.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/error_screen.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 3 chunks +7 lines, -8 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/chromeos.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M chromeos/login/auth/authenticator.h View 4 chunks +6 lines, -10 lines 0 comments Download
M chromeos/login/auth/authenticator.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.h View 3 chunks +4 lines, -7 lines 0 comments Download
M chromeos/login/auth/cryptohome_authenticator.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D chromeos/login/auth/login_performer.h View 1 chunk +0 lines, -232 lines 0 comments Download
D chromeos/login/auth/login_performer.cc View 1 chunk +0 lines, -309 lines 0 comments Download
M chromeos/login/auth/mock_authenticator.h View 2 chunks +3 lines, -5 lines 0 comments Download
M chromeos/login/auth/mock_authenticator.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Nikita (slow)
Created Revert of Extract LoginPerformer to chromeos/auth
6 years, 1 month ago (2014-10-25 19:12:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681593003/1
6 years, 1 month ago (2014-10-25 19:12:51 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/chromeos/login/existing_user_controller.cc: While running git apply --index -3 -p1; error: patch ...
6 years, 1 month ago (2014-10-25 19:13:24 UTC) #4
Nikita (slow)
I'm going to revert manually to resolve conflicts.
6 years, 1 month ago (2014-10-25 19:14:33 UTC) #6
Nikita (slow)
6 years, 1 month ago (2014-10-25 19:28:34 UTC) #7
Message was sent while issue was closed.
On 2014/10/25 19:14:33, Nikita Kostylev wrote:
> I'm going to revert manually to resolve conflicts.

Not doing revert after all, see
https://code.google.com/p/chromium/issues/detail?id=426522#c9

Powered by Google App Engine
This is Rietveld 408576698