Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: sky/engine/core/page/FocusController.cpp

Issue 681553003: Remove a bunch of unused or never-set settings. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/page/EventHandler.cpp ('k') | sky/engine/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/page/FocusController.cpp
diff --git a/sky/engine/core/page/FocusController.cpp b/sky/engine/core/page/FocusController.cpp
index 29ce9d9e0183f57853b9a7d411b4b61feb73555a..b22b33972ef1d065f2fe77c85d66713fde705210 100644
--- a/sky/engine/core/page/FocusController.cpp
+++ b/sky/engine/core/page/FocusController.cpp
@@ -334,11 +334,6 @@ bool FocusController::advanceFocusInDocumentOrder(FocusType type, bool initialFo
Document* document = frame->document();
Node* currentNode = document->focusedElement();
- // FIXME: Not quite correct when it comes to focus transitions leaving/entering the WebView itself
- bool caretBrowsing = frame->settings() && frame->settings()->caretBrowsingEnabled();
-
- if (caretBrowsing && !currentNode)
- currentNode = frame->selection().start().deprecatedNode();
document->updateLayoutIgnorePendingStylesheets();
@@ -385,12 +380,6 @@ bool FocusController::advanceFocusInDocumentOrder(FocusType type, bool initialFo
setFocusedFrame(newDocument.frame());
- if (caretBrowsing) {
- Position position = firstPositionInOrBeforeNode(element);
- VisibleSelection newSelection(position, position, DOWNSTREAM);
- frame->selection().setSelection(newSelection);
- }
-
element->focus(false, type);
return true;
}
« no previous file with comments | « sky/engine/core/page/EventHandler.cpp ('k') | sky/engine/core/rendering/RenderBlock.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698