Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 681553003: Remove a bunch of unused or never-set settings. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove a bunch of unused or never-set settings. Just mechanical changes. No change in behavior. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/dcb6d5fe5589ba1249a1588977b856b18ccdf87b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -344 lines) Patch
M sky/engine/core/css/FontSize.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Position.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/editing/Caret.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/core/editing/Caret.cpp View 2 chunks +2 lines, -15 lines 0 comments Download
M sky/engine/core/editing/EditorCommand.cpp View 3 chunks +24 lines, -43 lines 0 comments Download
M sky/engine/core/editing/FrameSelection.cpp View 4 chunks +2 lines, -17 lines 0 comments Download
M sky/engine/core/frame/Settings.in View 8 chunks +0 lines, -54 lines 0 comments Download
M sky/engine/core/page/EventHandler.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M sky/engine/core/page/FocusController.cpp View 2 chunks +0 lines, -11 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.cpp View 1 chunk +8 lines, -17 lines 0 comments Download
M sky/engine/public/web/WebRuntimeFeatures.h View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/public/web/WebSettings.h View 4 chunks +0 lines, -30 lines 0 comments Download
M sky/engine/web/WebRuntimeFeatures.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M sky/engine/web/WebSettingsImpl.h View 5 chunks +0 lines, -23 lines 0 comments Download
M sky/engine/web/WebSettingsImpl.cpp View 9 chunks +0 lines, -105 lines 0 comments Download
M sky/engine/web/WebViewImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M sky/engine/web/WebViewImpl.cpp View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years, 1 month ago (2014-10-26 01:54:48 UTC) #2
abarth-chromium
LGTM
6 years, 1 month ago (2014-10-26 02:10:05 UTC) #3
ojan
6 years, 1 month ago (2014-10-26 05:51:45 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
dcb6d5fe5589ba1249a1588977b856b18ccdf87b.

Powered by Google App Engine
This is Rietveld 408576698