Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 681533002: remove DIR_LOCAL_APP_DATA_LOW from base. (Closed)

Created:
6 years, 2 months ago by cpu_(ooo_6.6-7.5)
Modified:
6 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

remove DIR_LOCAL_APP_DATA_LOW from base. Not used except for cloud print. BUG=426573 TBR=rvargas Committed: https://crrev.com/1b29da2e5a43c42752b8bf489880a82eaf04b930 Cr-Commit-Position: refs/heads/master@{#301473}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -29 lines) Patch
M base/base_paths_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/base_paths_win.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M base/path_service_unittest.cc View 1 chunk +2 lines, -12 lines 0 comments Download
M cloud_print/virtual_driver/win/port_monitor/port_monitor.cc View 1 chunk +14 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
cpu_(ooo_6.6-7.5)
the other two owners seem to be on vacation. ptal.
6 years, 1 month ago (2014-10-27 19:25:52 UTC) #2
scottmg
lgtm Could we make the default LocalLow instead?
6 years, 1 month ago (2014-10-27 20:02:43 UTC) #3
cpu_(ooo_6.6-7.5)
can't because low integrity folders cannot be read from medium integrity processes. The biba model ...
6 years, 1 month ago (2014-10-27 21:57:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681533002/1
6 years, 1 month ago (2014-10-27 22:02:36 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-27 23:14:22 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 23:15:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1b29da2e5a43c42752b8bf489880a82eaf04b930
Cr-Commit-Position: refs/heads/master@{#301473}

Powered by Google App Engine
This is Rietveld 408576698