XMLHttpRequest.responseURL should exclude url fragment

XMLHttpRequest.responseURL should exclude url
fragment

According to the specification of responseURL, it will return empty string
if the response URL is null otherwise it will return its serialization with exclude fragment flag set.

Specs : https://xhr.spec.whatwg.org/#the-responseurl-attribute

To check this added test for URL like "/xmlhttprequest/navigation-target.html#foobar"
in responseURL.html test, according to specs for this case responseURL attribute will return url excluding fragments.

So removing fragments from response URL in responseURL() method.
R=habib.virji@samsung.com
BUG=427789
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184513

[Paritosh Kumar, 2014-10-27 10:49:17]

PTAL.

[Paritosh Kumar, 2014-10-27 11:44:31]

paritosh.in@samsung.com changed reviewers:
+ yhirano@chromium.org

[Paritosh Kumar, 2014-10-27 11:46:45]

paritosh.in@samsung.com changed reviewers:
- habib.virji@samsung.com

[Paritosh Kumar, 2014-10-27 11:47:03]

PTAL.

[Paritosh Kumar, 2014-10-27 11:47:45]

paritosh.in@samsung.com changed reviewers:
+ habib.virji@chromium.org

[Paritosh Kumar, 2014-10-27 12:31:33]

paritosh.in@samsung.com changed reviewers:
+ habib.virji@samsung.com
- habib.virji@chromium.org, yhirano@chromium.org

[Habib Virji, 2014-10-27 17:29:03]

Your changes look okay. This area is new to me, so cannot comment on it. 

Your explanation is not straightforward, would be better if you can specify
"serialization without exclude fragment flag" is properly explained above.

[Paritosh Kumar, 2014-10-28 03:43:16]

paritosh.in@samsung.com changed reviewers:
+ yhirano@chromium.org
- habib.virji@samsung.com

[Paritosh Kumar, 2014-10-28 03:43:17]

PTAL.

[Paritosh Kumar, 2014-10-28 03:44:00]

paritosh.in@samsung.com changed reviewers:
+ habib.virji@samsung.com

[yhirano, 2014-10-28 03:59:53]

Please remove [WIP] from the title and the description if you want to land this
CL.

> responseURL attribute should return url without "#bar/baz+xml" but not
returning that.
Sorry I don't understand the sentence: What do you mean by it?

https://codereview.chromium.org/681513003/diff/1/LayoutTests/http/tests/xmlht...
File LayoutTests/http/tests/xmlhttprequest/responseURL.html (right):

https://codereview.chromium.org/681513003/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/responseURL.html:44: return
get('/xmlhttprequest/supported-xml-content-types.cgi?type=foo#bar/baz+xml',
'xml');
Can you tell me why you use such a complex URL?

[Paritosh Kumar, 2014-10-28 04:26:29]

Thanks. PTAL..

> Please remove [WIP] from the title and the description if you 
> want to land this CL.

Updated.

> >responseURL attribute should return url without "#bar/baz+xml" but not
returning that.
> Sorry I don't understand the sentence: What do you mean by it?

Edited in the description.

https://codereview.chromium.org/681513003/diff/1/LayoutTests/http/tests/xmlht...
File LayoutTests/http/tests/xmlhttprequest/responseURL.html (right):

https://codereview.chromium.org/681513003/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/responseURL.html:44: return
get('/xmlhttprequest/supported-xml-content-types.cgi?type=foo#bar/baz+xml',
'xml');
On 2014/10/28 03:59:53, yhirano wrote:
> Can you tell me why you use such a complex URL?

Just To test for URL with fragments..

[yhirano, 2014-10-28 05:08:06]

https://codereview.chromium.org/681513003/diff/1/LayoutTests/http/tests/xmlht...
File LayoutTests/http/tests/xmlhttprequest/responseURL.html (right):

https://codereview.chromium.org/681513003/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/responseURL.html:44: return
get('/xmlhttprequest/supported-xml-content-types.cgi?type=foo#bar/baz+xml',
'xml');
On 2014/10/28 04:26:28, Paritosh Kumar wrote:
> On 2014/10/28 03:59:53, yhirano wrote:
> > Can you tell me why you use such a complex URL?
> 
> Just To test for URL with fragments.. 

Then, isn't resources/test.html#foobar enough?

[yhirano, 2014-10-28 05:18:07]

And, please file a bug.

[Paritosh Kumar, 2014-10-28 05:44:59]

Thanks

Updated as suggested and filed the bug (http://crbug.com/427789).

PTAL.

https://codereview.chromium.org/681513003/diff/1/LayoutTests/http/tests/xmlht...
File LayoutTests/http/tests/xmlhttprequest/responseURL.html (right):

https://codereview.chromium.org/681513003/diff/1/LayoutTests/http/tests/xmlht...
LayoutTests/http/tests/xmlhttprequest/responseURL.html:44: return
get('/xmlhttprequest/supported-xml-content-types.cgi?type=foo#bar/baz+xml',
'xml');
On 2014/10/28 05:08:05, yhirano wrote:
> On 2014/10/28 04:26:28, Paritosh Kumar wrote:
> > On 2014/10/28 03:59:53, yhirano wrote:
> > > Can you tell me why you use such a complex URL?
> > 
> > Just To test for URL with fragments.. 
> 
> Then, isn't resources/test.html#foobar enough?

Yes.. Done.

[yhirano, 2014-10-28 05:54:51]

The title looks a bit vague: "XMLHttpRequest.responseURL should exclude url
fragment" might be better?

Please update the description: the test target name is old.

https://codereview.chromium.org/681513003/diff/20001/LayoutTests/http/tests/x...
File LayoutTests/http/tests/xmlhttprequest/responseURL.html (right):

https://codereview.chromium.org/681513003/diff/20001/LayoutTests/http/tests/x...
LayoutTests/http/tests/xmlhttprequest/responseURL.html:44: return
get('resources/navigation-target.html#foobar', 'html');
There is no 'html' response type. Maybe 'text'?
https://xhr.spec.whatwg.org/#the-responsetype-attribute

[Paritosh Kumar, 2014-10-28 06:02:21]

Thanks

Updated as suggested, PTAL.

https://codereview.chromium.org/681513003/diff/20001/LayoutTests/http/tests/x...
File LayoutTests/http/tests/xmlhttprequest/responseURL.html (right):

https://codereview.chromium.org/681513003/diff/20001/LayoutTests/http/tests/x...
LayoutTests/http/tests/xmlhttprequest/responseURL.html:44: return
get('resources/navigation-target.html#foobar', 'html');
On 2014/10/28 05:54:50, yhirano wrote:
> There is no 'html' response type. Maybe 'text'?
> https://xhr.spec.whatwg.org/#the-responsetype-attribute

Thanks. Done.

[yhirano, 2014-10-28 06:12:41]

LGTM

You need an owner's approval: I recommend sigbjorn@opera.com or
kouhei@chromium.org.

[Paritosh Kumar, 2014-10-28 06:13:50]

paritosh.in@samsung.com changed reviewers:
+ kouhei@chromium.org

[Paritosh Kumar, 2014-10-28 06:13:51]

PTAL.

[Paritosh Kumar, 2014-10-28 06:16:51]

paritosh.in@samsung.com changed reviewers:
+ sigbjorn@opera.com
- habib.virji@samsung.com, kouhei@chromium.org, yhirano@chromium.org

[Paritosh Kumar, 2014-10-28 06:16:52]

PTAL.

[Paritosh Kumar, 2014-10-28 06:17:51]

paritosh.in@samsung.com changed reviewers:
+ habib.virji@samsung.com, kouhei@chromium.org, yhirano@chromium.org

[kouhei (in TOK), 2014-10-28 06:20:16]

On 2014/10/28 06:16:52, Paritosh Kumar wrote:
> PTAL.

Lgtm

[Paritosh Kumar, 2014-10-28 06:20:37]

The CQ bit was checked by paritosh.in@samsung.com

[Paritosh Kumar, 2014-10-28 06:20:47]

The CQ bit was unchecked by paritosh.in@samsung.com

[Paritosh Kumar, 2014-10-28 06:21:45]

The CQ bit was checked by paritosh.in@samsung.com

[commit-bot: I haz the power, 2014-10-28 06:22:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/681513003/40001

[commit-bot: I haz the power, 2014-10-28 08:53:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-28 08:53:01]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33885)

[kouhei (in TOK), 2014-10-28 08:58:03]

Sorry to interrupt this, but would you add an entry to AUTHORS file before
submitting this CL?
Also, please sign our CLA form at https://cla.developers.google.com/clas

[Paritosh Kumar, 2014-10-28 09:23:18]

> Sorry to interrupt this, but would you add an entry to AUTHORS file before
> submitting this CL?

Added Myself to AUTHORS file https://codereview.chromium.org/549933003/

> Also, please sign our CLA form at https://cla.developers.google.com/clas

Already signed CLA from Samsung.

[Paritosh Kumar, 2014-10-28 11:53:35]

The CQ bit was checked by paritosh.in@samsung.com

[commit-bot: I haz the power, 2014-10-28 11:54:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/681513003/40001

[commit-bot: I haz the power, 2014-10-28 12:48:00]

Committed patchset #3 (id:40001) as 184513