Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 681513002: Add semicolons to import statements in .mojom files. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -64 lines) Patch
M mojo/examples/surfaces_app/child.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/examples/window_manager/window_manager.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/application/application.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/application/shell.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_factory.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_import2.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_structs.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom/parse/parser.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/pylib/mojom_tests/parse/parser_unittest.py View 4 chunks +15 lines, -5 lines 0 comments Download
M mojo/services/public/interfaces/content_handler/content_handler.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/gpu/gpu.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/input_events/input_events.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/public/interfaces/native_viewport/native_viewport.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/navigation/navigation.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/network/network_service.mojom View 1 chunk +8 lines, -8 lines 0 comments Download
M mojo/services/public/interfaces/network/tcp_bound_socket.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/network/tcp_server_socket.mojom View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/services/public/interfaces/network/udp_socket.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/network/url_loader.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/network/web_socket.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/surfaces/quads.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surfaces.mojom View 1 chunk +4 lines, -4 lines 0 comments Download
M mojo/services/public/interfaces/surfaces/surfaces_service.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/services/public/interfaces/view_manager/view_manager.mojom View 1 chunk +5 lines, -5 lines 0 comments Download
M mojo/services/public/interfaces/window_manager/window_manager.mojom View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/shell/external_application_registrar.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 2 months ago (2014-10-25 00:02:27 UTC) #1
jamesr
lgtm
6 years, 1 month ago (2014-10-27 05:06:02 UTC) #2
viettrungluu
6 years, 1 month ago (2014-10-27 18:27:25 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
251f5b90f1debc3711f75281212adb07030db768 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698