Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: tools/perf/benchmarks/blink_perf.py

Issue 681493002: Add full frame measurement mode for some blink_perf tests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/benchmarks/blink_perf.py
diff --git a/tools/perf/benchmarks/blink_perf.py b/tools/perf/benchmarks/blink_perf.py
index 20d3a025ebceeb4bfbb020b69684339d4fe674d4..6838b998ad877e163fb7a1c2e3849ce09907a692 100644
--- a/tools/perf/benchmarks/blink_perf.py
+++ b/tools/perf/benchmarks/blink_perf.py
@@ -70,11 +70,19 @@ class _BlinkPerfMeasurement(page_test.PageTest):
def WillNavigateToPage(self, page, tab):
page.script_to_evaluate_on_commit = self._blink_perf_js
+ # Some blink perf tests require content_shell with window.intenals API.
+ def CustomizeFinderOptions(self, options):
tonyg 2014/10/27 19:11:57 This doesn't seem right. We shouldn't just change
Xianzhu 2014/10/27 20:43:28 We want to let the tests cover the cost of composi
+ if options.browser_type == 'release':
+ options.browser_type = 'content-shell-release'
+ elif options.browser_type == 'debug':
+ options.browser_type = 'content-shell-debug'
+
def CustomizeBrowserOptions(self, options):
options.AppendExtraBrowserArgs([
'--js-flags=--expose_gc',
'--enable-experimental-web-platform-features',
- '--disable-gesture-requirement-for-media-playback'
+ '--disable-gesture-requirement-for-media-playback',
+ '--expose-internals-for-testing'
])
def ValidateAndMeasurePage(self, page, tab, results):
« no previous file with comments | « no previous file | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698