Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(568)

Issue 681483003: Fix a typo in an OAuth2TokenService classname (Closed)

Created:
6 years, 2 months ago by James Cook
Modified:
6 years, 1 month ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a typo in an OAuth2TokenService classname Also fix some linter errors. BUG=none TEST=compiles Committed: https://crrev.com/a3ea7ac28857f5b088518383d789e948da1325be Cr-Commit-Position: refs/heads/master@{#301378}

Patch Set 1 #

Patch Set 2 : fix ios #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M chrome/browser/signin/android_profile_oauth2_token_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/fake_profile_oauth2_token_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/mutable_profile_oauth2_token_service.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M components/signin/ios/browser/profile_oauth2_token_service_ios.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.h View 3 chunks +6 lines, -6 lines 0 comments Download
M google_apis/gaia/oauth2_token_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
James Cook
rogerta, PTAL - I just happened to notice this while working on a different CL. ...
6 years, 2 months ago (2014-10-24 23:11:19 UTC) #2
Roger Tawa OOO till Jul 10th
Lgtm Thanks! I was planning to get to this at some point ☺
6 years, 2 months ago (2014-10-25 00:03:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681483003/1
6 years, 1 month ago (2014-10-26 19:47:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/27627)
6 years, 1 month ago (2014-10-26 19:57:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/681483003/40001
6 years, 1 month ago (2014-10-27 15:49:31 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-27 16:37:01 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 16:37:36 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a3ea7ac28857f5b088518383d789e948da1325be
Cr-Commit-Position: refs/heads/master@{#301378}

Powered by Google App Engine
This is Rietveld 408576698