Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1214)

Unified Diff: components/gcm_driver/gcm_client_impl_unittest.cc

Issue 681453004: [GCM] Adding last token fetching time handling (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_client_impl_unittest.cc
diff --git a/components/gcm_driver/gcm_client_impl_unittest.cc b/components/gcm_driver/gcm_client_impl_unittest.cc
index 8257f1cfc567ad056a0bbda5354b0149df87ed92..7bd39173992db2b5bfaa03773dca988184c44148 100644
--- a/components/gcm_driver/gcm_client_impl_unittest.cc
+++ b/components/gcm_driver/gcm_client_impl_unittest.cc
@@ -278,7 +278,8 @@ class GCMClientImplTest : public testing::Test,
const gcm::GCMClient::SendErrorDetails& send_error_details) override;
void OnSendAcknowledged(const std::string& app_id,
const std::string& message_id) override;
- void OnGCMReady(const std::vector<AccountMapping>& account_mappings) override;
+ void OnGCMReady(const std::vector<AccountMapping>& account_mappings,
+ const base::Time& last_token_fetching_time) override;
void OnActivityRecorded() override {}
void OnConnected(const net::IPEndPoint& ip_endpoint) override {}
void OnDisconnected() override {}
@@ -514,9 +515,11 @@ void GCMClientImplTest::ReceiveOnMessageSentToMCS(
}
void GCMClientImplTest::OnGCMReady(
- const std::vector<AccountMapping>& account_mappings) {
+ const std::vector<AccountMapping>& account_mappings,
+ const base::Time& last_token_fetching_time) {
last_event_ = LOADING_COMPLETED;
QuitLoop();
+ // TODO(fgorski): Add tests for last_token_fetching_time.
// TODO(fgorski): Add scenario verifying contents of account_mappings, when
// the list is not empty.
}

Powered by Google App Engine
This is Rietveld 408576698