[GCM] Adding last token fetching time handling

[GCM] Adding last token fetching time handling

Adding SetLastTokenFetchingTime to GCMStore
Adding Get/SetLastTokenFetchingTime to GCMDriver
Propagating the last token fetching time up and down the GCM stack

BUG=374969
Committed: https://crrev.com/5df101705a650995d1709deb0a57b5dce4e61e91
Cr-Commit-Position: refs/heads/master@{#301545}

[fgorski, 2014-10-27 19:18:56]

fgorski@chromium.org changed reviewers:
+ zea@chromium.org

[fgorski, 2014-10-27 19:18:56]

PTAL

[Nicolas Zea, 2014-10-27 21:54:55]

LGTM, with a request: what do you think about s/fetching/fetch? I.e.
SetLastTokenFetchingTime -> SetLastTokenFetchTime? Just because its more
concise.

https://codereview.chromium.org/681453004/diff/1/google_apis/gcm/engine/gcm_s...
File google_apis/gcm/engine/gcm_store_impl.h (right):

https://codereview.chromium.org/681453004/diff/1/google_apis/gcm/engine/gcm_s...
google_apis/gcm/engine/gcm_store_impl.h:94: // Sets the time of last token
fetching time.
nit: "Sets last token fetch time", here and elsewhere.

https://codereview.chromium.org/681453004/diff/1/google_apis/gcm/engine/gcm_s...
File google_apis/gcm/engine/gcm_store_impl_unittest.cc (right):

https://codereview.chromium.org/681453004/diff/1/google_apis/gcm/engine/gcm_s...
google_apis/gcm/engine/gcm_store_impl_unittest.cc:650:
&GCMStoreImplTest::LoadCallback, base::Unretained(this), &load_result));
verify the initial value is unset?

[fgorski, 2014-10-27 23:46:27]

Feedback applied. Missing test added in place of a TODO

https://codereview.chromium.org/681453004/diff/1/google_apis/gcm/engine/gcm_s...
File google_apis/gcm/engine/gcm_store_impl.h (right):

https://codereview.chromium.org/681453004/diff/1/google_apis/gcm/engine/gcm_s...
google_apis/gcm/engine/gcm_store_impl.h:94: // Sets the time of last token
fetching time.
On 2014/10/27 21:54:55, Nicolas Zea wrote:
> nit: "Sets last token fetch time", here and elsewhere.

Done.

https://codereview.chromium.org/681453004/diff/1/google_apis/gcm/engine/gcm_s...
File google_apis/gcm/engine/gcm_store_impl_unittest.cc (right):

https://codereview.chromium.org/681453004/diff/1/google_apis/gcm/engine/gcm_s...
google_apis/gcm/engine/gcm_store_impl_unittest.cc:650:
&GCMStoreImplTest::LoadCallback, base::Unretained(this), &load_result));
On 2014/10/27 21:54:55, Nicolas Zea wrote:
> verify the initial value is unset?

Done.

[fgorski, 2014-10-28 00:50:41]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2014-10-28 00:55:37]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2014-10-28 00:55:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/681453004/40001

[commit-bot: I haz the power, 2014-10-28 02:09:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-28 02:10:23]

Patchset 3 (id:??) landed as
https://crrev.com/5df101705a650995d1709deb0a57b5dce4e61e91
Cr-Commit-Position: refs/heads/master@{#301545}