Update the sw_reporter version code

Update the sw_reporter version code

This will work better with the new 3 part version, where the minor
version is now the 2nd last element, instead of the last.

BUG=

Committed: https://crrev.com/e201af8f8620a6858bdb722d7b81b61c4648ea4b
Cr-Commit-Position: refs/heads/master@{#302702}

[csharp, 2014-10-28 19:09:32]

csharp@chromium.org changed reviewers:
+ mad@chromium.org

[csharp, 2014-10-28 19:09:33]

https://codereview.chromium.org/681423002/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/sw_reporter_installer_win.cc (right):

https://codereview.chromium.org/681423002/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/sw_reporter_installer_win.cc:110: // The major
version for X.Y.Z is X*256^3+Y*256+Z. If there are additional
I removed the talked about what component maps to which word and just added the
expression. I think this seems clearer, but let me know if that is just me being
crazy :)

[MAD, 2014-10-29 01:06:50]

Comments are good, I would just remove an unnecessary if() and add DCHECKs...

And you should also add a crbug so we can add for merge once it landed on Canary
for a day or two.

Thanks!

BYE
MAD

https://codereview.chromium.org/681423002/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/sw_reporter_installer_win.cc (right):

https://codereview.chromium.org/681423002/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/sw_reporter_installer_win.cc:110: // The major
version for X.Y.Z is X*256^3+Y*256+Z. If there are additional
On 2014/10/28 19:09:33, csharp wrote:
> I removed the talked about what component maps to which word and just added
the
> expression. I think this seems clearer, but let me know if that is just me
being
> crazy :)

Acknowledged.

https://codereview.chromium.org/681423002/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/sw_reporter_installer_win.cc:114: if
(version.components().size() >= 1)
Since we DCHECK that components() is not empty above, we don't need to test for
>= 1 (and we already used [0] above even when size <= 1.

https://codereview.chromium.org/681423002/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/sw_reporter_installer_win.cc:115: major_version
= 0x1000000 * version.components()[0];
We should add DCHECKs that components are of the expected sizes, e.g., < 0x100
for the first and third, and smaller than 0x10000 for the second one.

[csharp, 2014-10-31 14:29:48]

https://codereview.chromium.org/681423002/diff/1/chrome/browser/component_upd...
File chrome/browser/component_updater/sw_reporter_installer_win.cc (right):

https://codereview.chromium.org/681423002/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/sw_reporter_installer_win.cc:114: if
(version.components().size() >= 1)
On 2014/10/29 01:06:50, MAD wrote:
> Since we DCHECK that components() is not empty above, we don't need to test
for
> >= 1 (and we already used [0] above even when size <= 1.

Done.

https://codereview.chromium.org/681423002/diff/1/chrome/browser/component_upd...
chrome/browser/component_updater/sw_reporter_installer_win.cc:115: major_version
= 0x1000000 * version.components()[0];
On 2014/10/29 01:06:50, MAD wrote:
> We should add DCHECKs that components are of the expected sizes, e.g., < 0x100
> for the first and third, and smaller than 0x10000 for the second one.

Done.

[MAD, 2014-11-04 17:32:08]

lgtm

[csharp, 2014-11-04 20:48:44]

The CQ bit was checked by csharp@chromium.org

[commit-bot: I haz the power, 2014-11-04 20:50:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/681423002/20001

[commit-bot: I haz the power, 2014-11-04 20:57:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-04 20:57:05]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[csharp, 2014-11-04 20:58:18]

csharp@chromium.org changed reviewers:
+ waffles@chromium.org

[csharp, 2014-11-04 20:58:18]

waffles@ for owner's approval. Thanks

[csharp, 2014-11-04 20:58:20]

waffles@ for owner's approval. Thanks

[waffles, 2014-11-04 21:21:25]

lgtm

https://codereview.chromium.org/681423002/diff/20001/chrome/browser/component...
File chrome/browser/component_updater/sw_reporter_installer_win.cc (right):

https://codereview.chromium.org/681423002/diff/20001/chrome/browser/component...
chrome/browser/component_updater/sw_reporter_installer_win.cc:116: // missing
values are just replaced by zero.
Maybe clarify that "1" the same as 1.0.0, not 0.0.1.

[csharp, 2014-11-04 21:47:03]

The CQ bit was checked by csharp@chromium.org

[csharp, 2014-11-04 21:47:27]

The CQ bit was unchecked by csharp@chromium.org

[csharp, 2014-11-04 21:56:49]

https://codereview.chromium.org/681423002/diff/20001/chrome/browser/component...
File chrome/browser/component_updater/sw_reporter_installer_win.cc (right):

https://codereview.chromium.org/681423002/diff/20001/chrome/browser/component...
chrome/browser/component_updater/sw_reporter_installer_win.cc:116: // missing
values are just replaced by zero.
On 2014/11/04 21:21:25, waffles wrote:
> Maybe clarify that "1" the same as 1.0.0, not 0.0.1.

Done.

[csharp, 2014-11-04 21:56:56]

The CQ bit was checked by csharp@chromium.org

[commit-bot: I haz the power, 2014-11-04 21:58:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/681423002/40001

[commit-bot: I haz the power, 2014-11-04 23:14:11]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-11-04 23:15:09]

Patchset 3 (id:??) landed as
https://crrev.com/e201af8f8620a6858bdb722d7b81b61c4648ea4b
Cr-Commit-Position: refs/heads/master@{#302702}